search

OpenLiberty / ci.maven

Maven plugins for managing Liberty profile servers #devops
Apache License 2.0
130 stars 91 forks source link

Start dev mode in a container fails when there is a space character in the path #1830

Closed turkeylurkey closed 2 months ago

turkeylurkey commented 2 months ago

When you use the command mvn liberty:devc to start dev mode in a directory and the directory has a space character somewhere in the name then an error is printed and the command fails.

The issue also occurs when you use Gradle. One directory is called demo devmode.

> Task :libertyDevc
/Users/pa/demo devmode/build/wlp/usr/servers/defaultServer/configDropins/overrides/liberty-plugin-variable-config.xml file deleted before processing plugin configuration.
Building Docker image...
docker build --pull -f /Users/pa/demo devmode/build/.libertyDevc/tempDockerfile13265352539165646922 -t demo-devmode-gradle-dev-mode /Users/pa/demo devmode
DEPRECATED: The legacy builder is deprecated and will be removed in a future release.
            BuildKit is currently disabled; enable it by removing the DOCKER_BUILDKIT=0
            environment-variable.

"docker build" requires exactly 1 argument.
See 'docker build --help'.

Usage:  docker build [OPTIONS] PATH | URL | -

Build an image from a Dockerfile

> Task :libertyDevc FAILED
cherylking commented 2 months ago

We fixed this several months ago. Not sure how it's happening again?

cherylking commented 2 months ago

@turkeylurkey What version of the plugin were you using? The message you showed above is not used in any recent version.

Building Docker image...

It now prints:

Building container image...
cherylking commented 2 months ago

The fix was in LMP 3.10.x and LGP 3.8.x.

turkeylurkey commented 2 months ago

Thanks for the update. Our test case is using 3.6.2.