OpenLiberty / ci.maven

Maven plugins for managing Liberty profile servers #devops
Apache License 2.0
130 stars 91 forks source link

looseApplication has no effect #1841

Open bmarwell opened 4 weeks ago

bmarwell commented 4 weeks ago

Hi,

looseApplication seems broken. Although I set it to false, an XML file will be created when running mvn package liberty:dev.

https://github.com/OpenLiberty/ci.maven/blob/main/docs/deploy.md

Reproducer:

           <plugin>
                <groupId>io.openliberty.tools</groupId>
                <artifactId>liberty-maven-plugin</artifactId>
                <configuration>
                    <appsDirectory>apps</appsDirectory>
                    <looseApplication>false</looseApplication>
                    <stripVersion>true</stripVersion>
                    <userDirectory>${project.build.directory}/wlp-usr</userDirectory>
                    <outputDirectory>${project.build.directory}/wlp-out</outputDirectory>
                </configuration>
            </plugin>

There will be an xml in apps, not a war file.

cherylking commented 4 weeks ago

@bmarwell dev mode requires loose application. You should see a log message indicating this. See this line of code. We do have some inconsistencies that were found recently though and are documented here.

bmarwell commented 4 weeks ago

Thanks. I hadn't seen the actual warning, so please excuse this oversight.

I wanted to try a jar file, because Microsoft Playwright seems to have difficulties with wsjar: protocols, but luckily that can be disabled. However, it only runs on ubuntu...

Currently, I am trying to circumvent it by building my own Dockerfile, as there are no new ubuntu-jdk21+ OL images released, neither on DockerHub nor on icr.io (which can't be searched without an account). Because of this, this issue can be considered low priority, at least for me.

Thanks for looking into it anyway!