search

OpenLiberty / devfile-stack

Application stack for Open Liberty
Apache License 2.0
10 stars 8 forks source link

Multi-module push doesn't work when top-level reactor build is a peer of the individual module directories #161

Open scottkurz opened 3 years ago

scottkurz commented 3 years ago

For a project structure like: https://github.com/IBMTechSales/openshift-workshop-was/tree/master/labs/Openshift/RuntimeModernization/app

the subdirectories are:

CustomerOrderServices CustomerOrderServicesApp CustomerOrderServicesProject
CustomerOrderServicesTest CustomerOrderServicesWeb

with CustomerOrderServicesProject the "top-level" POM from the reactor build perspective.

If we do odo push we're going to fail since there's no pom.xml in the parent directory '..../app' which contains all these modules.

Even if it's not feasible to write a single devfile that works for all possible module layouts.. we should at least give some guidance, possibly a better error msg even, for a structure like this.

And we might want to have a "root_module" devfile variable perhaps.