Peer Review/Testing for Mac

[shin19991207]

Peer Review conducted on 3 platforms: Mac, Windows & Linux

• Mac OS is our base OS as the dev content team generally develops on the Mac OS.
• Conduct three separate peer reviews for each OS.

Peer Review: review to be done by a peer member.

Functionality

• [x] Check that the guide has working instructions and sample code
• [x] If any URL visits, try them on different browsers: Firefox, Chrome, Safari
• [x] If any URL visits, try curl command where applicable

Formatting & Presentation

README.adoc checks:

• [x] Ensure that command substitutions use the $(cmd) format and not `cmd`
• [x] Ensure that the console output of the integrated tests do not include the [INFO] tab
• [x] Check the quality and presentation of guide according to Structure and Style Guideline
• [x] Check that the pom.xml, server.xml, etc files are clean
  • [x] Remove any dependencies and features that are not required
  • [x] Ensure that the parent pom.xml files do not contain any dependencies, and all dependencies are specified in the children pom.xml files
• [x] Examples with the right outcomes are provided
• [x] Examples with the wrong outcomes, if any, are provided

pom.xml checks (if files are present):

• [x] Check that the file follows the template found here: https://github.com/OpenLiberty/draft-guides-template/blob/draft/finish/pom.xml
• [x] Check that the following dependencies are included in all of the pom.xml files:

  
  <!-- Provided dependencies -->
  <dependency>
  <groupId>jakarta.platform</groupId>
  <artifactId>jakarta.jakartaee-api</artifactId>
  <version>8.0.0</version>
  <scope>provided</scope>
  </dependency>

org.eclipse.microprofilemicroprofile 4.0.1 pom provided

- [x]  Check that the versions of plugins are directly provided and not fed in by a file property.
  - Not formatted like so:

<properties>
    <!-- Plugins -->
    <version.liberty-maven-plugin>3.4</version.liberty-maven-plugin>
</properties>

<!-- Liberty plugin -->
<plugin>
    <groupId>io.openliberty.tools</groupId>
    <artifactId>liberty-maven-plugin</artifactId>
    <version>${version.liberty-maven-plugin}</version>
</plugin>

  - Should be formatted like so:

<!-- Liberty plugin -->
<plugin>
    <groupId>io.openliberty.tools</groupId>
    <artifactId>liberty-maven-plugin</artifactId>
    <version>3.4</version>
</plugin>

- [x] Check that there are 4 spaces per indent for proper formatting
- [x] Ensure that the guide is using the latest version of the `liberty-maven-plugin` or `liberty-gradle-plugin` where applicable

Overall checks:
- [x] Check the consistency of guide with the template and other guides
- [x] Check the quality of code according to the best coding practices
- [x] Check that all licensing statements are properly stated in all files, with the correct year (Should be present in all Java files + the `index.html`)
- [x] Check that the directories are properly structured
- [x] Check that some of these `page-tags` are used in a guide: `MicroProfile, Maven, Docker, Kubernetes, Gradle, Java EE, Security, Cloud`. Only these tags are visible on the website. Latest list [here](https://github.com/OpenLiberty/guides-common/blob/master/guide_tags.json). 
- [x] Check the `attribution` statement is accurate for the guide
- [x] Verify the GitHub Actions scripts, if any, are accurate and consistent with other guides

---

- [ ] Additional tests where applicable: 
    - [ ] Define test coverage and review with team (including guide contributor, if available)
    - [ ] Define detail test cases 
    - [ ] Consider corner cases targeting the specific guide
    - [ ] Consider corner cases UI tests
    - [ ] Consider testing URL on all browsers, ie, FF, Chrome, Safari
    - [x] Consider testing the `curl` command for URL visits
    - [x] Make sure the index.html information is correct by visiting the root, e.g. `http://localhost:9080`
- [ ] Consider building with both Maven and Gradle build tools 
- [ ] Testing with different IDEs, ie, Atom, Eclipse (Optional: VS.code, IntelliJ, Microclimate)
- [ ] Run Acrolinx Checker on draft (above 70 score approximately)
- [x] Consider SEO title and description for the guides 
- [x] Ensure automated tests with GitHub Actions are enabled
- [ ] Run `diff -r start/ finish/` and there's no differences
- [x] Ensure that the automation tests are able to run when PR is created
- [x] Check the appearance of the guide on test site for the following items: 
    - [ ] Table of contents 
    - [ ] Headings
    - [ ] Paragraphs
    - [ ] code snippets
    - [ ] outputs
    - [ ] links
    - [ ] hotspots 
- [x] Test the guide end-to-end with working instruction and sample code
- [x] Perform all the defined test cases 

[jakub-pomykala]

Completed end to end - no issues.