OpenLiberty / guide-cdi-intro

An introductory guide on how to use Contexts and Dependency Injection to manage and inject dependencies into microservices: https://openliberty.io/guides/cdi-intro.html
Other
6 stars 18 forks source link

suggested note about this guide not being ideal for real world setup #141

Open stguitar opened 4 years ago

stguitar commented 4 years ago

This guide creates a single deployable package (war) for 2 microservices.

The guide uses HTTP to communicate between these 2 services, to prove a point but this is not practical in real world usage. Typically, since all of the classes are in the same class path, you would just execute various methods on the injected classes directly, rather than making HTTP calls to get data between the 'services'.

It might be helpful to simply add a disclaimer note on the guide at a few points to point this fact out.

yeekangc commented 4 years ago

Thank you, @stguitar. We should either split things up or put a note as you said.

@gkwan-ibm

salmad3 commented 4 years ago

I would suggest we update the application to a more practical use case, such as data being hosted on an origin, where the CORS application, hosted on another origin, would access that data.