OpenLiberty / guide-cloud-ibm

A guide on how to deploy microservices to IBM Cloud Kubernetes Service (IKS) and IBM Cloud Private (ICP): https://openliberty.io/guides/cloud-ibm.html
Other
3 stars 4 forks source link

Review comments #24

Closed yeekangc closed 5 years ago

yeekangc commented 5 years ago

@gkwan-ibm

andrewdes commented 5 years ago

What's the thinking behind the section on deploying a new version of the system service? Should it be a top-level section?

The thought behind this section was to teach users how to redeploy a microservice after they've made changes to it (similar to the Redeploy microservices) section in the kube-intro guide. Looking at the guide, I think this section should be a top-level section. It will also keep it consistent with the guides we have out there that do something similar.

yeekangc commented 5 years ago

Thank you, @andrewdes. That's good thinking. I will call out the context further beyond what we have at the moment. For example, you have made some changes, you want to re-deploy, here is how you can do it.

evelinec commented 5 years ago

@yeekangc can you review the changes for this issue and close when ready. Thanks.