Multipane Issues

[justineechen]

• [x] <execution /> element tag in Building your application has the slash in the wrong place

• [x] PropertiesResource should be one word in Testing the container and file should be removed

• [x] Change the endpoint of your application from /properties to /properties-new by replacing the PropertiesResource.java class and changing the @Path annotation to "properties-new".* should be Change the endpoint of your application from /properties to /properties-new by changing the @Path annotation to "properties-new".*

[justineechen]

https://github.com/OpenLiberty/guide-docker/commit/cb7af331c83e19bde4eb05928e02503776220e6d

[justineechen]

• [x] Parent POM

"Theinstall-apps goal copies the application into the specified directory of the specified server. In this case, the goal copies the rest.war file into the apps directory of the defaultServer server."

was removed because the install-apps goal was removed with the parent pom update

• [x] Format files
• [x] Failsafe Plugin
• [x] .yaml quiet flag

[justineechen]

• [x] "Now that your image is built, execute the Docker run command with the absolute path to this guide, from the command line to run it:"

  docker run -d --name rest-app -p 9080:9080 -p 9443:9443 -v <absolute path to guide>/start/target/liberty/wlp/usr/servers:/servers ol-runtime

[Rachelwrq]

Build your application:

• [x] ….”REST application to the defaultServer server.pom.xml” is unclear Execution element hotspot: should it include the comment? And also it appears that the hotspot covered everything underneath

Creating the Dockerfile

• [x] Switch the order between CMD and ENTRYPOINT?

Testing the container

• [x] Hotspot for action arrow: exclude the package and import above
• [x] It says /properties on the guide, but there is no / in the code on the right

[justineechen]

• [x] "Learn how to containerize a microservice with Docker for iterative development." -> with the period

[justineechen]

• [x] The implementation of the REST application can be found in the start/src directory.

[Rachelwrq]

Checklist for multipane conversion

Through the browser:

• [x] Read over guide and run through all commands (copy and paste using browser etc..)
• [x] Test the actual application (use it, hit endpoints, etc.)
• [x] No files in the middle panel (guide section)
• [x] Appropriate files are being displayed on the right hand side at the right time
• [x] Any mention of code in the right panel should be hot spotted
• [x] Make sure hotspots actually point to the correct lines
• [x] Any actions to the code (Create, replace) should be put in an arrow (code_command)
• [x] All code commands are highlighting the right code
• [x] Any actions to look at the code should be a hotspot
• [x] Guide attribution is present

In the README.adoc:

• [x] Tags in the front matter are correct
  • [x] If :page-guide-category: none remove :page-essential: and :page-essential-order:

In other files:

• [x] Failsafe plugin and Surefire plugin updates if applicable
• [x] Parent POM update
  • [x] start directory
  • [x] finish directory
• [x] Files are formatted correctly
• [x] .travis.yaml file is updated accordingly

[andrewdes]

Your pom.xml file is already configured to add your REST application to the defaultServer.

But you can tweak this configuration or add your own for another server by updating the element.

• [x] Above should be combined to be one paragraph
• [x] <execution/> hotspot showing wrong lines
• [x] "Create the Docker file." -> "Create the Dockerfile."
• [x] “In this case, you’re using the openliberty/open-liberty:javaee7 image as your parent image, which comes with the latest Open Liberty runtime.” Should this be Java EE 8?
• [x] .yaml file needs -q flag

[justineechen]

• [ ] System/Properties endpoint doesn't work after pom update

[Rachelwrq]

• [x] Add more hotspots for commands Creating the Dockerfile Section
• [x] In Testing the container section: mvn package command is not in the right format

[justineechen]

2nd round:

• [x] guide author
• [x] update to master
• [x] mvn instructions
• [x] if there is a clean comment, let consider or discuss it
• [x] make sure liberty:stop-server before the testing (assumed testing is at the end)

[justineechen]

This guide has successfully been converted to multipane and has no blockers.