search

OpenLiberty / guide-kubernetes-intro

An introductory guide on how to deploy microservices to a Kubernetes cluster and manage them with the Kubernetes CLI: https://openliberty.io/guides/kubernetes-intro.html
Other
20 stars 23 forks source link

Feedback #68

Closed andrewdes closed 6 years ago

andrewdes commented 6 years ago

The way it is currently makes it sound like there is only one version of Docker that has Docker Desktop support.

I realize the guide says to verify name:1.0-SNAPSHOT and name:1.0-SNAPSHOT are among the list (which they were), but I am not sure there is a point listing out images in the guide output that aren't present.

But in the guide it only shows how to scale and doesn't actually demonstrate how to descale your deployments. Perhaps you can provide more details in the scaling section (as suggested here https://github.com/OpenLiberty/guide-kubernetes-intro/issues/63) and explain the --replicas=3 part of the command and how decreasing the replicas allows you to descale? Or w.e. the correct way to descale your deployments in kubernetes is.

I understand this is expected behaviour, but perhaps it might be worth mentioning. Since the section before this is "Scaling a deployment" and someone might expect to see 3 name pods after redeploying. Or even just as a friendly reminder that after redeploying, you will have to rescale.

yeekangc commented 6 years ago

@proubatsis, I thought "Make sure you have the Docker version with the Docker Desktop support" is fixed?

We should either say use a Docker Desktop version with Kubernetes support or use the latest version.

yeekangc commented 6 years ago

The comments on the Scaling section relate to #63.

proubatsis commented 6 years ago

@yeekangc The PR is available, just needs to be approved and merged: https://github.com/OpenLiberty/guides-common/pull/185

yeekangc commented 6 years ago

Thank you, @proubatsis. I reviewed, approved and merged. The next OL.io refresh should pick it up.

proubatsis commented 6 years ago

PR Merged