search

OpenLiberty / guide-maven-intro

An introductory guide on how to build applications using Maven on Open Liberty: https://openliberty.io/guides/maven-intro.html
Other
20 stars 34 forks source link

User feedback #49

Closed yeekangc closed 5 years ago

yeekangc commented 5 years ago

In the pom.xml: Could not find project.build.directory's value Googled https://cwiki.apache.org/confluence/display/MAVEN/Maven+Properties+Guide

For the Liberty server: Could not see in the servers/GettingStartedServer/apps/getting-started.war.xml folder where the app classes and xml files are Could not see what the app structure is, the name of the servlet and there was not a link to exercise the HelloServlet

Tried to find the URL from the Test file: Could not find property project.artifactId mentioned in the pom.xml Googled but could not find a value for it

The property is used to derive the war.name property below:
The JUnit test has: public static void init() { String port = System.getProperty("liberty.test.port"); String war = System.getProperty("war.name"); URL = "http://localhost:" + port + "/" + war + "/" + "servlet"; }

Could not find what war.name is looking backwards into the xml file

yeekangc commented 5 years ago

@gkwan-ibm @jzoght

jzoght commented 5 years ago

YK, @yeekangc

I found that I was reading the "Build a web application with maven" while looking at the guide-getting-started folder.

I like to update the above to be:

a missing URL to test the app after the mvn liberty:start-server command. The link to exercise the app should be provided.

The details about how the app was deployed using the server/apps/ServletSample.war.xml file should have a link to explain it or go over it a bit in the guide. I am used to dropping the .war in the dropins or apps folder. I never used a app.war.xml before to deploy a liberty app.

Thanks.

gkwan-ibm commented 5 years ago

a missing URL to test the app after the mvn liberty:start-server command. The link to exercise the app should be provided.

We will fix this

The details about how the app was deployed using the server/apps/ServletSample.war.xml file should have a link to explain it or go over it a bit in the guide. I am used to dropping the .war in the dropins or apps folder. I never used a app.war.xml before to deploy a liberty app.

The guides do not focus on how to use Liberty, so they do not talk about ServletSample.war.xml which is Liberty supported feature for looseApplication (See this doc)