evelinec
commented
4 years ago - [x] pom.xml comments can be deleted? ie,
<!--
<configuration>
<serverName>guideServer</serverName>
</configuration>
-->Looks like the above is described in the guide:
In the liberty-maven-plugin plugin section, you can add a <configuration/> element to specify Open Liberty configuration details.
Then, perhaps for this guide, this config should be used and shown, ie, not to be commented out?
- [x] The hotspot should be specific for
<serverName/>but the entire configuration block:
For example, you can add the <serverName/> field to define the name of the Open Liberty server that Maven creates.
-
[x] Add the
<!-- For testing -->comment for the test dependencies in the pom. -
[x] HelloServlet.java method comments to be hidden? ie,
/**
* @see HttpServlet#doGet(HttpServletRequest request, HttpServletResponse response)
*//**
* @see HttpServlet#doPost(HttpServletRequest request, HttpServletResponse response)
*/-
[x] The license year for
readme.adocshould be updated to:/ Copyright (c) 2017, 2019 IBM Corporation and others. -
[x] The test script,
scripts/travisTest.sh, may be better to use the one with the comments. It's in the template repo. -
[x] Ran
diffonstartandfinishdirectory and there's a difference for theserver.xmlfile:
diff -r start/src/main/liberty/config/server.xml finish/src/main/liberty/config/server.xml
10,11c10,13
< <httpEndpoint httpPort="${default.http.port}" httpsPort="${default.https.port}" id="defaultHttpEndpoint" host="*" />
<
---
> <!-- tag::httpEndpoint[] -->
> <httpEndpoint httpPort="${default.http.port}"
> httpsPort="${default.https.port}" id="defaultHttpEndpoint" host="*" />
> <!-- end::httpEndpoint[] -->
13d14
< 
NimG98
66