search

OpenLiberty / guide-maven-intro

An introductory guide on how to build applications using Maven on Open Liberty: https://openliberty.io/guides/maven-intro.html
Other
20 stars 34 forks source link

content update including gradle-maven comparison #98

Closed AustinSeto closed 3 years ago

AustinSeto commented 4 years ago

Addresses: https://github.com/OpenLiberty/guide-maven-intro/issues/23 & https://github.com/OpenLiberty/guide-maven-intro/issues/35

Other related issue: https://github.com/openliberty/guide-gradle-intro/issues/11 Related PR: https://github.com/OpenLiberty/guide-gradle-intro/pull/73 Related PR: https://github.com/OpenLiberty/guide-maven-intro/pull/37 (old PR for same issue)

yeekangc commented 4 years ago

@gkwan-ibm, are we sure we want to add such comparisons to the guides? Cc @lauracowen.

gkwan-ibm commented 4 years ago

@AustinSeto, It may be a miscommunication. We should just update the content of "One benefit of using..." paragraph in both guides instead of create a new section to compare Maven and Gradle.

gkwan-ibm commented 4 years ago

@scottkurz would you review this PR?

yeekangc commented 4 years ago

I am on the fence on this PR. We should further review and discuss the changes before committing.

yeekangc commented 4 years ago

If we want or need to elaborate on the differences between Maven and Gradle, adding an optional section towards the end is an option. And, I will focus on the actual technical differences and state them as-is vs qualitative or potential differences due to preferences.

Then, the guides should focus on how you will build with Maven or Gradle in any case. It's not meant to compare and contrast the 2 technologies. Users can choose what work best for them.

yeekangc commented 3 years ago

+1 to the approach to provide additional background and relevant considerations to users on why a build tool like Maven or Gradle may be used within the respective guide directly.

-1 to an direct side-by-side comparison, which isn't what the guides are meant to do.

AustinSeto commented 3 years ago

Thank you for the review @Charlotte-Holt, I've implemented all suggested changes. Let me know what you think.