Closed salmad3 closed 4 years ago
Execute the following commands to build the image using the Dockerfile, run it in a Docker container, and map port 27017 from the container to your host machine:
Noticed rest of feedback is repetitive with https://github.com/OpenLiberty/draft-guide-mongodb/issues/28 & https://github.com/OpenLiberty/draft-guide-mongodb/issues/26
@DannyS03 ready for review
Feedback addressed.
Peer Review: review to be done by a peer member.
Functionality
curl
command where applicableFormatting & Presentation
$(cmd)
format and not`cmd`
[INFO]
tabpom.xml
,server.xml
, etc files are cleanliberty-maven-plugin
orliberty-gradle-plugin
where applicablepage-tags
are used in a guide:MicroProfile, Maven, Docker, Kubernetes, Gradle, Java EE, Security, Cloud
. Only these tags are visible on the website. Latest list here.attribution
statement is accurate for the guidetravisTest.sh
script, if any, is accurate and consistent with other guidesPeer Testing: tests to be done by a peer member.
Guide’s contributor’s (if available, otherwise peer tester’s) responsibility:
curl
command for URL visitsdiff -r start/ finish/
and there's no differencesPeer Tester’s responsibility: