mswatosh
commented
4 years ago I built the docker file and started the container, then copied the truststore and started the server. Whenever I try to interact with the application I just get SRVE0190E: File not found: /api/crew/
The application doesn't work and the tests fail. Is this a known issue?
What you’ll learn
- "JSON format" should be "JSON-like format"
I'm worried the setup is too complicated, and that it might scare away users looking to quickly setup mongoldb with Open Liberty. The docker file is pretty complicated, could we just provide a certificate instead of generating it to simplify?
Potentially instead of making changes to the mongo docker image, just use the command line args: docker run -d -v /path/to/pem/:/etc/ssl/ mongo:3.6 --tlsMode requireTLS --tlsCertificateKeyFile /etc/ssl/mongodb.pem
Starting the Open Liberty server in development mode & Configuring with MicroProfile Config
- One part says command line and the other says shell session, this should be consistent.
Read
- enpoint should be endpoint
CrewService.java should have the methods organized in the same order as the guide, so the autoscrolling doesn't jump around so much.
Running the micro service
- "The application guide-mongodb-intro updated in 1.023 seconds." seems like a better message to watch for
The test section goes into detail on testing in general, is there a guide we could point to instead, so the section could be more relevant to the mongodb tests?
I would recommend against the underscore notation in the test class. It's uncommon in Java and inconsistent with the rest of the code base.
The package for the test class should start io.openliberty not it.io.openliberty.
jimmy1wu
SME Review:
Review of the guide by a Subject Matter Expert (SME) for technical accuracy and content.