I couldn't address a few things from #6 since it corresponds to my open PR #8, making a note of all the things I need to verify is addressed in the PR before merging:
[x] Check that the pom.xml, server.xml, etc files are clean (Doesn't contain unnecessary dependancies, are properly formatted, labelled if necessary)
[x] Ensure that the guide is using the latest version of the liberty-maven-plugin or liberty-gradle-plugin where applicable
[x] pom.xml hotspots (system.ip and inventory.ip) aren't highlighting anything (address after simplifying pom).
[x] mvn verify command \ is messing up when you click the copy button and paste it into the terminal (Windows issue?)
[x] the first part of the command mvn verify -Ddockerfile.skip=true is automatically run, without the rest of the command
MaiHameed
commented
4 years ago
I couldn't address a few things from #6 since it corresponds to my open PR #8, making a note of all the things I need to verify is addressed in the PR before merging:
[x] Check that the
pom.xml,server.xml, etc files are clean (Doesn't contain unnecessary dependancies, are properly formatted, labelled if necessary)[x] Ensure that the guide is using the latest version of the
liberty-maven-pluginorliberty-gradle-pluginwhere applicable[x] pom.xml hotspots (
system.ipandinventory.ip) aren't highlighting anything (address after simplifying pom).[x]
mvn verifycommand\is messing up when you click the copy button and paste it into the terminal (Windows issue?)[x] the first part of the command
mvn verify -Ddockerfile.skip=trueis automatically run, without the rest of the command