OpenLiberty / guide-rest-client-reactjs

A guide on how to access a simple RESTful web service and consume its resources with ReactJS in Open Liberty.
https://openliberty.io/guides/rest-client-reactjs.html
Other
1 stars 1 forks source link

Updating react-table to v7 #122

Closed jakub-pomykala closed 1 year ago

jakub-pomykala commented 1 year ago
jakub-pomykala commented 1 year ago

For the super-linter check the env option to VALIDATE_CSS is set to false but it was still running checks on the CSS with jscpd. I managed to remove the failure by setting CSS styling that was flagged as clone to multiple elements at the same time.

gkwan-ibm commented 1 year ago

Also, there are two // tag::table[] showing in the table and better update the table screenshot in the "Try what you’ll build" section because the table bottom looks differently.

Screen Shot 2023-01-25 at 4 50 11 PM

gkwan-ibm commented 1 year ago

At "Importing the HTTP client" subsection,

gkwan-ibm commented 1 year ago

Failed to run mvn process-resources in the "Building and packaging the front end" section

[INFO] Creating an optimized production build...
[INFO] Failed to compile.
[INFO] 
[INFO] Attempted import error: './Components/App' does not contain a default export (imported as 'App').
[INFO] 
[INFO] 
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  01:28 min
[INFO] Finished at: 2023-01-25T17:20:00-05:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.10.0:npm (npm run build) on project guide-rest-client-reactjs: Failed to run task: 'npm run build' failed. org.apache.commons.exec.ExecuteException: Process exited with an error: 1 (Exit value: 1) -> [Help 1]
jakub-pomykala commented 1 year ago

In regards to this comment: I have run end to end and detected no issues.

gkwan-ibm commented 1 year ago
jakub-pomykala commented 1 year ago

Changes done - but once again no issues running the app which straight away displays the table..

gkwan-ibm commented 1 year ago
jakub-pomykala commented 1 year ago

Comment adressed in 866d616 and 78452b4

gkwan-ibm commented 1 year ago