multipane issues - Githubissues

gkwan-ibm commented 5 years ago

[x] no git clone command on the right pane
[x] the URL "Creating a MicroProfile application" point to CDI guide, it should be incorrect.
[x] instruction does not ask reader to navigate to start directory to start
[x] Create the InventoryResource class but InventoryResource already exist in the start directory. The original guide does not ask to create. So the multipane should ask to read it
[x] http://localhost:9080/inventory/hosts/<hostname>; should remove the semi-colon. If possible, treat it as an non URL link
[ ] at the "Testing the hypermedia-driven RESTful web service" section, suggest to add http://localhost:9080/inventory/hosts/localhost
[x] the hotspot GET in the following should highlight the Response targetResponse... instead of targetResponse.close();
- Finally, the method visitLocalhost creates a GET request to the system service, registering the localhost system.
[x] Rewrite the "Running the tests" section, so that to run mvn liberty:stop-server first then run mvn install
[ ] the test failed

justineechen commented 5 years ago

The link https://openliberty.io/guides/microprofile-intro.html that this guide points to doesn't exist anymore. I will remove this sentence.
Do we want to replace http://localhost:9080/inventory/hosts/{hostname}[http://localhost:9080/inventory/hosts/{hostname}^] and give the users localhost directly for the link in Testing?

evelinec commented 5 years ago

Found the fixed the code_command for "InventoryUtil" isn't pointing to the correct file issue in https://github.com/OpenLiberty/guide-rest-hateoas/commit/bb6436f85379aa529fad8cbfadc7ed31e6c05432.

evelinec commented 5 years ago

Test had passed when I tried it today.

evelinec commented 5 years ago

Verified all the points in the description of this issue, except for this one:

at the "Testing the hypermedia-driven RESTful web service" section, suggest to add http://localhost:9080/inventory/hosts/localhost

Not sure that's needed.

evelinec commented 5 years ago

@gkwan-ibm Do you want to take a quick look to see if everything is ok to close this issue? Thanks.

gkwan-ibm commented 5 years ago

Verified all the points in the description of this issue, except for this one:
* at the "Testing the hypermedia-driven RESTful web service" section, suggest to add http://localhost:9080/inventory/hosts/localhost
Not sure that's needed.

That should be resolved

evelinec commented 5 years ago

Verified all the points in the description of this issue, except for this one:
* at the "Testing the hypermedia-driven RESTful web service" section, suggest to add http://localhost:9080/inventory/hosts/localhost
Not sure that's needed.
That should be resolved

The comment was, the issue had been fixed already.

OpenLiberty / guide-rest-hateoas

multipane issues #40