Pass in parent classloader when initiating ByteClassLoader and catch LinkageErrors - Githubissues

OpenLiberty / liberty-arquillian

Arquillian Liberty Managed and Remote containers

Apache License 2.0

11 stars 29 forks source link

Pass in parent classloader when initiating ByteClassLoader and catch LinkageErrors #110

Closed kathrynkodama closed 3 years ago

kathrynkodama commented 3 years ago

Signed-off-by: Kathryn Kodama kathryn.s.kodama@gmail.com

Short description of what this resolves:

Resolves LinkageErrors encountered as conflicts between ClassLoaders:

java.lang.LinkageError: loading constraint violation: loader "io/openliberty/arquillian/managed/ByteClassLoader@d82648bf"
 previously initiated loading for a different type with name 
"org/jboss/cdi/tck/tests/implementation/builtin/metadata/session/BakeryProductDecorator" defined by loader 
"jdk/internal/loader/ClassLoaders$AppClassLoader@4e391aa3

Changes proposed in this pull request:

Pass in the system class loader as the parent when ByteClassLoader is initialized, so that parent class loader is tried first
Catch LinkageErrors and return an empty list of servlet names, the default "ArquillianServletRunnerEE9" will be used