search

OpenLiberty / liberty-arquillian

Arquillian Liberty Managed and Remote containers
Apache License 2.0
11 stars 29 forks source link

Suggested Junit5 test method #127

Closed KyleAure closed 1 year ago

KyleAure commented 1 year ago

Related #124

cherylking commented 1 year ago

@KyleAure Thanks for the PR. When I started looking into this last week, I was attempting to update the dependency in https://github.com/OpenLiberty/arquillian-liberty-dependencies. With the changes you are making in this PR, would there still need to be updates made to that repo as well?

KyleAure commented 1 year ago

Hey @cherylking, Yes, this is just an example of one of the ways we could test junit5 in this repo. Though this isn't currently working since the sub-project I added isn't a module and therefore unit tests aren't run. I'm not sure this is the correct way to test this.
Instead, I think it would be better to test junit5 as part of just the liberty-remote project.

KyleAure commented 1 year ago

Deleting this PR as this testing would be better done on the liberty-dependencies repo