Closed HasseNasse closed 5 years ago
I'm thinking that it's most likely preferable to call
bin/server stop
instop()
rather than just killing the server process? Other than that the changes look good to me. Also I would just point out that we should probably refactor to use the Liberty Ant Plugin at some point in the future.
I`ll give the gracefull shutdown comment a look whenever possible.
The shut down hook has now been updated, would be nice to merge this PR as we are wanting to run Integration Tests on our application using the liberty-managed adapter with the added functionalities.
Short description of what this resolves:
Summary of discussion #40:
bin/server
shellscript already handles jvm.options + server.env pre-processing before server start-up, we would wantliberty-managed
to re-use this script rather than programmatically tailoring its own.19.0.0.1?
will support passing generic JVM arguments to thebin/server
Changes proposed in this pull request:
bin/server run <servername>
used to start server with ConsoleConsumer. Comment: Tests passing.-Dcom.ibm.ws.logging.console.log.level=INFO
Comment:19.0.0.2
would have allowed the passing of JVM args directly to the shell script. However, this would cause issues with older versions of liberty. The proposed solution (@aguibert ) is to useJAVA_TOOL_OPTIONS
onProcessBuilder
which should work for all JDKs.bin/server stop
List will be updated as work goes on..
Fixes: #40