OpenLiberty / liberty-arquillian

Arquillian Liberty Managed and Remote containers
Apache License 2.0
11 stars 29 forks source link

'bin/server' shellscript execution instead of 'bin/tools/ws-server.jar' #42

Closed HasseNasse closed 5 years ago

HasseNasse commented 5 years ago

Short description of what this resolves:

Summary of discussion #40:

Changes proposed in this pull request:

List will be updated as work goes on..

Fixes: #40

HasseNasse commented 5 years ago

42 can be reviewed again for possible issues now. Change requests have been implemented. In addition, squash-commit 24365be can be viewed to see all changes + messages.

HasseNasse commented 5 years ago

I'm thinking that it's most likely preferable to call bin/server stop in stop() rather than just killing the server process? Other than that the changes look good to me. Also I would just point out that we should probably refactor to use the Liberty Ant Plugin at some point in the future.

I`ll give the gracefull shutdown comment a look whenever possible.

HasseNasse commented 5 years ago

The shut down hook has now been updated, would be nice to merge this PR as we are wanting to run Integration Tests on our application using the liberty-managed adapter with the added functionalities.