OpenLiberty / liberty-arquillian

Arquillian Liberty Managed and Remote containers
Apache License 2.0
10 stars 29 forks source link

Server is not stopped at the end of the test run on Windows #49

Closed Azquelt closed 5 years ago

Azquelt commented 5 years ago
Issue Overview

On Windows platform, the container does not stop the server

Expected Behaviour

Server stops

Current Behaviour

Server continues running after the test is over

Steps To Reproduce
  1. Run a test without starting the server beforehand
  2. Check task manager to see that the server is still running after the test is complete
Additional Information

I'm guessing that this was caused by #42 which changed start() to call the bin/server scripts but did not change stop() which still destroys the process started by start().

On *nix systems, terminating the process started as bin/server run is sufficient to signal the server to shut down gracefully.

On Windows, it appears to kill off the cmd.exe process running server.bat but does not kill the child java.exe process which is the actual server

I would try calling server stop instead of trying to kill the process directly.

Azquelt commented 5 years ago

I am working on a fix to this