OpenLiberty / liberty-bikes

Real-time web based multiplayer game running on OpenLiberty
http://libertybikes.mybluemix.net
Eclipse Public License 1.0
37 stars 38 forks source link

Fix bug where game service would get stuck on a deleted round #240

Closed aguibert closed 5 years ago

aguibert commented 5 years ago

Ryan pointed out a bug where if you do:

The game-service would get stuck saying round XXXX did not exist. This was because when we deleted an unstarted game in GameRoundService.deleteRound() we just set the game state to FINISHED and didn't go through the GameRound.endGame() code which would take care of the round cleanup including invoking the callback that advanced the party to next round.