Consider changes needed to handle new possibility of server config <include> elements pointing to a directory

OpenLiberty / liberty-language-server

The Liberty Config Language Server provides language server features for Liberty server configuration files through any of the supported client IDEs.

Eclipse Public License 2.0

5 stars 11 forks source link

Consider changes needed to handle new possibility of server config <include> elements pointing to a directory #204

Closed cherylking closed 9 months ago

cherylking commented 1 year ago

This OpenLiberty issue https://github.com/OpenLiberty/open-liberty/issues/25149 adds support for the element location attribute to point to a directory containing server config files. This will affect any lemminx-liberty code that processes the server.xml <include> elements.

cherylking commented 1 year ago

The OL issue is currently targeted for 23.0.0.10 which has an eGA of 10/17. It is also planned to be included in the 23.0.0.10-beta which has an eGA of 9/19.

evie-lau commented 10 months ago

Checklist

[x] Diagnostics
- [x] Allow recognizing directories
- [x] Validate if directory exists for diagnostics
- [x] Add tests
- [x] Test all the above in Windows

EDIT: the below will be left to address in #230 for processing features. Leaving this issue to only address existing behavior for include directory.

[ ] Processing
- [ ] Process directory direct children XML files alphabetically
- [ ] Overlapping work with #230 where XML files in include dir need to be processed for features as wel
Make sure to test on Windows as well

cherylking commented 10 months ago

Should we also add the two way check that LMP/LGP is doing?

[x] If specify a directory, and it is a file issue a diagnostic.
[x] If specify a file, and it is a directory issue a diagnostic.