search

OpenLiberty / liberty-language-server

The Liberty Config Language Server provides language server features for Liberty server configuration files through any of the supported client IDEs.
Eclipse Public License 2.0
5 stars 11 forks source link

Narrow feature completion list and provide quick fix for invalid feature #214

Closed cherylking closed 1 year ago

cherylking commented 1 year ago

Related to #180

cherylking commented 1 year ago

This is what the quick fix looks like:

Screenshot 2023-09-08 at 1 39 25 PM

Screenshot 2023-09-08 at 1 39 10 PM

cherylking commented 1 year ago

Would this be merged into main as a completion list fix or 4q2023 with the addition of a new quick fix feature? Looks good to me either way.

@dshimo Good point. Originally I was just trying to fix the completion list. But this is more of an enhancement that should probably be targeted to 4q2023. Is it easy to change the PR to target a different branch? Or do I need to close this one and open a new one?

dshimo commented 1 year ago

@cherylking Seems like you got it. We're good to merge