search

OpenLiberty / liberty-language-server

The Liberty Config Language Server provides language server features for Liberty server configuration files through any of the supported client IDEs.
Eclipse Public License 2.0
5 stars 11 forks source link

Server.xml completion can include features with incompatible version numbers #275

Open turkeylurkey opened 5 months ago

turkeylurkey commented 5 months ago

If I start typing a feature name and use completion the server will not suggest features which are not compatible with existing features. In this case we do not see other versions of jakartaee.

image

However if I do not start typing a feature name the server will give the full list of available features even ones incompatible with existing features. I would expect similar filtering to the previous example.

image

The problem becomes worse when I type ja because local filtering then displays the incompatible features.

image
turkeylurkey commented 5 months ago

Related to #161

cherylking commented 5 months ago

If I start typing a feature name and use completion the server will not suggest features which are not compatible with existing features.

@turkeylurkey This is not something that is enabled in the language server. I am not sure why you are only seeing those features, but we do nothing to detect incompatible features. There is an open issue for this functionality https://github.com/OpenLiberty/liberty-language-server/issues/70.

cherylking commented 5 months ago

@turkeylurkey So the term "incompatible features" was misleading. What you are pointing out is that we do not display different versions of an already included feature when feature completion is used.

Your point is taken that the initial list of features that is displayed when no completion is done could do the same filtering. We will look into this at some point, but it will not be a priority at the moment.