Handle feature names that changed

OpenLiberty / liberty-language-server

The Liberty Config Language Server provides language server features for Liberty server configuration files through any of the supported client IDEs.

Eclipse Public License 2.0

6 stars 12 forks source link

Handle feature names that changed #300

Closed cherylking closed 1 month ago

cherylking commented 2 months ago

There are features where the name has changed (e.g. jsp-2.3 changed to pages-3.0, ejb-3.2 changed to enterprisebeans-4.0). This affects checks that we currently do with versioned features and maybe versionless features. A hard-coded map has been added in the code here. We need to make use of this when checking for diagnostics related to features.

multiple versions of a feature - if jsp-2.3 and pages-3.0 are both specified, flag that as an error
we should flag an error if both jsp and pages are specified
we should flag an error if jsp and pages-3.0 are specified
any combination of versioned and versionless features that in essence means multiple of the same feature/technology are configured should flag an error diagnostic

Check to see if any of our quick fix suggestions should be modified also.

cherylking commented 1 month ago

Suggested wording from Liberty dev:

ERROR: The x feature cannot be configured with the y feature because they are two different versions of the same technology. Remove one of the features.

Further feedback suggests we should not use "technology" in the message. Message is still being worked on.

cherylking commented 1 month ago

ERROR: The jsp-2.3 feature cannot be configured with the pages-3.0 feature because they are different versions of the same feature. The feature name changed from jsp to pages for Jakarta EE. Remove one of the features.

arunvenmany-ibm commented 1 month ago

ERROR: The jsp-2.3 feature cannot be configured with the pages-3.0 feature because they are different versions of the same feature. The feature name changed from jsp to pages for Jakarta EE. Remove one of the features.

is all the featurename changes are for jakarta ee ? Otherwise we may need to customize message for different versions of microprofile as well,

cherylking commented 1 month ago

ERROR: The jsp-2.3 feature cannot be configured with the pages-3.0 feature because they are different versions of the same feature. The feature name changed from jsp to pages for Jakarta EE. Remove one of the features.

is all the featurename changes are for jakarta ee ? Otherwise we may need to customize message for different versions of microprofile as well,

Yes, all are for Jakarta EE.

cherylking commented 1 month ago

If something comes up in the future unrelated to Jakarta EE, we can handle it then.