search

OpenLiberty / liberty-tools-eclipse

Eclipse Public License 2.0
11 stars 8 forks source link

WDT + Liberty Tools Eclipse co-existence - server.xml double-click opens in WDT Liberty Configuration Editor rather than Generic Text Editor w/ LSP #202

Open scottkurz opened 1 year ago

scottkurz commented 1 year ago

TODO - provide recreate function. We'd have to go back to 2022-06 and Liberty Tools Eclipse v0.2 at this point.

Probably a low priority issue since WDT won't reach 2022-09 compat for some time.

scottkurz commented 1 year ago

We can pull this off the milestone and deal with in '23.

scottkurz commented 6 months ago

One option would be to override the content type bindings for the content types defined in https://github.com/OpenLiberty/open-liberty-tools/blob/integration/dev/com.ibm.ws.st.core/plugin.xml (copied below), to bind them to the generic text editor.

Perhaps we should do a design issue discussion first though.

  <extension point="org.eclipse.core.contenttype.contentTypes">
    <content-type
      id="com.ibm.ws.st.configuration"
      name="%contentType"
      file-extensions="xml"
      priority="normal"
      default-charset="UTF-8"
      base-type="org.eclipse.core.runtime.xml">
      <describer class="org.eclipse.core.runtime.content.XMLRootElementContentDescriber">
        <parameter name="element" value="server"/>
      </describer>
    </content-type>
    <content-type
      id="bootstrap.properties"
      name="%bootstrapContentType"
      priority="normal"
      default-charset="UTF-8"
      file-names="bootstrap.properties"
      base-type="org.eclipse.core.runtime.properties"/>
    <content-type
      id="jvm.options"
      name="%jvmOptionsContentType"
      priority="normal"
      default-charset="UTF-8"
      file-names="jvm.options"
      base-type="org.eclipse.core.runtime.properties"/>
    <content-type
      id="server.env"
      name="%serverEnvContentType"
      priority="normal"
      default-charset="UTF-8"
      file-names="server.env"
      base-type="org.eclipse.core.runtime.properties"/>
  </extension>