Open gkwan-ibm opened 1 year ago
@gkwan-ibm I'm having trouble recreating this.
Could you please explain the exact sequence in more detail ?
E.g.
I'm not even sure these are the exact best questions but I guess I'm just trying to think of what the relevant detail could be.
The server.xml contains the following:
<webApplication contextRoot="${default.context.root}"
location="inventory.war">
<application-bnd>
<security-role name="admin">
<group name="admin" />
</security-role>
<security-role name="user">
<group name="user" />
</security-role>
</application-bnd>
</webApplication>
</webApplication>
, hover the mouse on the <webApplication ...
tag as the following screenshot
Close with '</webApplication>'
linkTried to open the server.xml with Text Editor and XML Editior, both editors do not propose any action.
Just tried the completion code assist, I can see the end tag suggestion
Just confirmed this issue still exists in v0.9.2 on top of 23-0.
It looks to me like we should open a Lemminx issue for this one. In Lemminx v0.23.0 I see this relevant stack trace in the debugger
ETagRequiredCodeAction(CloseTagCodeAction).doCodeActionsForStartTagClosed(DOMElement, DOMDocument, Range, Diagnostic, List<CodeAction>) line: 209
ETagRequiredCodeAction(CloseTagCodeAction).doCodeAction(ICodeActionRequest, List<CodeAction>, CancelChecker) line: 58
ContentModelCodeActionParticipant.doCodeAction(ICodeActionRequest, List<CodeAction>, CancelChecker) line: 51
XMLCodeActions.doCodeActions(CodeActionContext, Range, DOMDocument, SharedSettings, CancelChecker) line: 60
XMLLanguageService.doCodeActions(CodeActionContext, Range, DOMDocument, SharedSettings, CancelChecker) line: 260
XMLTextDocumentService.lambda$codeAction$23(String, CodeActionParams, DOMDocument, CancelChecker) line: 476
Opened https://github.com/eclipse/lemminx/issues/1544 . Since this would require a lemminx enhancement, I labeled this as 'enhancement'.
Tried to fix the
webApplication
tag by the suggested actionthe proposed close action, paste the closing
</webApplication>
end-tag incorrectly at line 57