search

OpenLiberty / liberty-tools-eclipse

Eclipse Public License 2.0
13 stars 9 forks source link

SVT:Adding feature to server.xml to the end of the feature sequence sometimes removes some chars #405

Open rumanaHaque opened 1 year ago

rumanaHaque commented 1 year ago

While testing using ACME ee10 app - for TER https://github.ibm.com/websphere/system-test/issues/765 ran into this issues when adding features to the server.xml

When I click on <fe Ctrl+space, feature completion makes it

When I do app Ctrl+space, it shows diff options, including appAuthentication-2.0 When I select that feature, it adds it, but also removes the </ from the front of the feature. Here's a screenshot.

image

cherylking commented 12 months ago

Is this the same as #470 ?

scottkurz commented 9 months ago

Just noticing that in the screenshot and in my recreates in #470, the feature which this happened to was always the last one in the list, the one right before the </featureManager> end tag.

I have a vague sense that the Lemminx self-closing feature is somehow wrongly getting activated here. E.g. see the video recording here: https://github.com/eclipse/lemminx/issues/354 . Not sure it really helps all that much to note this even, but it's something I guess.

I don't think Lemminx has enough logging to turn on trace... e.g. if I look at https://github.com/eclipse/lemminx/blob/main/org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/services/format/XMLFormatterDocument.java which vaguely seems it might be relevant, it only seems to log maybe big error conditions.

I suppose enabling JDK trace like OpenJ9 Xtrace could be an option ... possibly for that class or the org.eclipse.lemminx.services.format.* package. Probably this is only worth doing if we can first know that we can recreate this consistently though.

scottkurz commented 9 months ago

Noticing too there is an extra closing bracket char '>' before the last feature. I wonder if that's relevant. I know, in the dup #470 issue it isn't there in the screenshot.. but perhaps that was removed before the screenshot was taken? IDK, maybe some fast typing and slow response gets the editor in some inconsistent syntax state, leading to this issue.

rumanaHaque commented 9 months ago

Just recreated this defect again today, using LTE version - 23.0.12.202311151445. I don't have the '>' while doing the recreate, as seen in this screenshot.

image