search

OpenLiberty / liberty-tools-eclipse

Eclipse Public License 2.0
11 stars 8 forks source link

Convert messages to nls format #419

Closed awisniew90 closed 1 year ago

awisniew90 commented 1 year ago

@dmuelle - Last time you had reviewed these messages, we did not have them consolidated in an nls props file. This PR does that, and we found a few messages that we had missed in the last ID review. Specifically, the last 7 messages here (line 78 and on): https://github.com/OpenLiberty/liberty-tools-eclipse/pull/419/files#diff-bc509bee7031fd55ada2ddb5421c7c609abbb0b4f8ccac213f15dfad7ed9c4a8

Would you be able to review those final 7 as well?

awisniew90 commented 1 year ago

Thanks @dmuelle - changed made and ready for re-review 👍

awisniew90 commented 1 year ago

@dmuelle - all good now 👍