OpenLiberty / liberty-tools-eclipse

Eclipse Public License 2.0
11 stars 8 forks source link

Change file monitoring for LCLS to support custom config files #429

Closed evie-lau closed 10 months ago

evie-lau commented 1 year ago

To support custom config files, after OpenLiberty/liberty-language-server#212 goes in, the IDE client side needs to be changed to monitor the following to send to LCLS:

https://github.com/OpenLiberty/liberty-tools-eclipse/blob/2fb4b6b2f3a87599c60e4571220eb593e5dd3cbe/bundles/io.openliberty.tools.eclipse.lsp4e/plugin.xml#L47-L67

Not changing it shouldn't break anything, but will not have support for custom config files.

Can model after https://github.com/OpenLiberty/liberty-tools-vscode/pull/286

scottkurz commented 1 year ago

Thx for the details.

Since not changing this shouldn't break anything I'll file this under the 23.0.12 milestone to target for that release.

evie-lau commented 1 year ago

An update: implementing this change also will not break anything - so it can be done anytime.

cherylking commented 11 months ago

Just a quick note that I think you need to change that same file to send all XML files to LCLS, instead of just server.xml. LCLS will then check for the server root element to decide if the file gets support.

scottkurz commented 11 months ago

Seems like we're not going to be able to get updates on the liberty plugin cfg via DidChangeWatchedFiles https://github.com/eclipse/lsp4e/issues/547

scottkurz commented 10 months ago

Closing this since we did the biggest piece in https://github.com/OpenLiberty/liberty-tools-eclipse/pull/460.

We still have a smaller effort remaining: https://github.com/OpenLiberty/liberty-tools-eclipse/issues/461 to be able to react dynamically to updates to the plugin cfg. For the time being the user will have to do some kind of restart...either of the IDE or dev mode. Would be nice to have doc but if we're going to fix anyway maybe it's not as much of a priority.