search

OpenLiberty / liberty-tools-intellij

IntelliJ IDEA extension for Liberty
https://plugins.jetbrains.com/plugin/14856-open-liberty-tools
Eclipse Public License 2.0
14 stars 26 forks source link

Replace the removed JSON classes with their corresponding new ones. #1119

Closed anusreelakshmi934 closed 1 day ago

anusreelakshmi934 commented 6 days ago

Update our source code to accommodate the replacement of certain JSON classes with the new ones introduced in IntelliJ 2024.3, as detailed here.

image

Identify the dependency of com.intellij.json.JsonFileType in source code as it is deprecated as per the document https://plugins.jetbrains.com/docs/intellij/api-changes-list-2024.html#json-plugin-new-20243.

dessina-devasia commented 5 days ago

As per the analysis com.intellij.json.JsonFileType is used in the class MicroProfileProjectService. But the function uses the JsonFileType is not used anywhere. So it is safe to delete the dependency. I've raised a PR with the corresponding changes.

PR: https://github.com/OpenLiberty/liberty-tools-intellij/pull/1125

angelozerr commented 5 days ago

I wonder if you need MicroProfileProjectService. I suppose that you did a copy paste from our old QuarkusProjectService which manages yaml completion based on mp properties.

In Quarkus we can declare properties in application.properties or application.yaml.

I am not sure that in MicroProfile you can declare properties in microprofile-config.yaml.

So perhaps you could skip this json support.

turkeylurkey commented 5 days ago

This issue does not show the Error Message in the description. Could you add that?

dessina-devasia commented 4 days ago

@turkeylurkey I've updated the description. Can you please let me know what does the error message means?