search

OpenLiberty / liberty-tools-intellij

IntelliJ IDEA extension for Liberty
https://plugins.jetbrains.com/plugin/14856-open-liberty-tools
Eclipse Public License 2.0
13 stars 26 forks source link

Consider giving user way to stop a Liberty server associated with current project even if terminal is closed #199

Open kathrynkodama opened 1 year ago

kathrynkodama commented 1 year ago

See https://github.com/OpenLiberty/liberty-tools-eclipse/issues/248

anusreelakshmi934 commented 8 months ago

If the server wasn't initiated within the ongoing Liberty Tools session, the 'stop' function in the dashboard will be ineffective. Consequently, when attempting to launch a new server, a message indicating that the server is already operational will appear. The server can solely be halted using 'mvn liberty:stop'.

JoshwinThomasIBM commented 1 month ago

The changes made in Liberty tools eclipse is they’ve added liberty stop action within the Liberty stop action button for any current running instances of liberty for that project, which may have been started away from eclipse. This allows a user to stop liberty, from the eclipse liberty dashboard itself. https://github.com/OpenLiberty/liberty-tools-eclipse/issues/248

This feature is not available in LT VS code as well as in LT IntelliJ. Currently for a user of these IDE's have to manually run the commands from the terminal for stopping liberty . Bringing the same solution which is implemented in LT eclipse, to other LT IDE's can be a resolution, which will also make the behaviour for liberty tools uniform across IDE's

The code changes made in liberty-tools eclipse project includes identifying the type of project (Maven/Gradle) and executing the commands to stop the running instances of the project as a job. https://github.com/OpenLiberty/liberty-tools-eclipse/pull/412

NB: if the projects are started within eclipse, then upon closing their terminal sessions would stop liberty on their respective projects