OpenLiberty / liberty-tools-intellij

IntelliJ IDEA extension for Liberty
https://plugins.jetbrains.com/plugin/14856-open-liberty-tools
Eclipse Public License 2.0
12 stars 24 forks source link

LSP4iJ 2024/04/01 integration: Upgrade to IntelliJ IDEA 2024.1. #722

Closed mrglavas closed 4 months ago

mrglavas commented 5 months ago

With https://github.com/OpenLiberty/liberty-tools-intellij/issues/723 resolved in IntelliJ IDEA 2024.1.1 we should probably target that version for testing.

Update build.gradle and plugin.xml so that LTI supports IntelliJ 2024.1 and launches 2024.1.1 with runIde.

Required test automation work to support 2024.1:

mrglavas commented 5 months ago

All of the automated tests on the draft PR failed catastrophically.

I haven't investigated what is going on with the automated UI tests yet but I suspect the runIde crashes: https://github.com/OpenLiberty/liberty-tools-intellij/issues/723 would contribute to that.

All of the Jakarta unit tests are failing with java.lang.NoSuchMethodError: 'void org.jetbrains.idea.maven.project.MavenWorkspaceSettingsComponent.loadState(org.jetbrains.idea.maven.project.MavenWorkspaceSettings).

Apparently the loadState method was deleted from 2024.1 and the version of the Maven test framework we were using is now incompatible. I did attempt to upgrade to the latest level of the JetBrains Maven test framework, but that causes compilation errors in all of our tests. I resolved those compilation errors in my local workspace but get no output for diagnostics. With my current draft changes, all of the tests continue to fail. Rather than continuing to chase a moving target, I wonder if we could just freeze the tests on the older IntelliJ platform libraries so that we don't need to keep updating them.