search

OpenLiberty / liberty-tools-intellij

IntelliJ IDEA extension for Liberty
https://plugins.jetbrains.com/plugin/14856-open-liberty-tools
Eclipse Public License 2.0
12 stars 24 forks source link

LSP4iJ 2024/04/01 integration: Completion does not overwrite the key text in bootstrap.properties #729

Closed turkeylurkey closed 5 months ago

turkeylurkey commented 5 months ago

When the user types text to select one of the keys in bootstrap.properties it is not replaced when the user selects one of the choices. image

turkeylurkey commented 5 months ago

Fixed by https://github.com/MicroShed/lsp4ij/pull/16

angelozerr commented 5 months ago

Just one question, have you the same problem with microprofile-config.properties?

I have tested quickly with our IJ Quarkus and we have not this problem.

The PR disable resolve completion, it is not the proper fix. If you have a problem with our LSP4IJ, please share your LSP trace.

I have started to write completion tests at https://github.com/redhat-developer/lsp4ij/tree/main/src/test/java/com/redhat/devtools/lsp4ij/features/completion to provide a robust completion without breaking something when complex completion code must be improved/fixed.

For instance see https://github.com/redhat-developer/lsp4ij/blob/637cd63d3b36c7571904849a32da934c8161d0d0/src/test/java/com/redhat/devtools/lsp4ij/features/completion/ClojureCompletionTest.java#L24

It would be nice to have your LSP trace and have a test with your usecase and fix it correctly if needed.

More we will have test, more LSP completion will be robust.

Thanks for sharing your LSP trace.