search

OpenLiberty / liberty-tools-intellij

IntelliJ IDEA extension for Liberty
https://plugins.jetbrains.com/plugin/14856-open-liberty-tools
Eclipse Public License 2.0
11 stars 20 forks source link

RemoveStaticModifierQuickFix is missing one target diagnostic in plugin.xml #766

Closed mrglavas closed 1 month ago

mrglavas commented 1 month ago

A mapping is required for the AnnotationConstants.DIAGNOSTIC_CODE_PREDESTROY_STATIC diagnostic.

In current https://github.com/eclipse/lsp4jakarta/blob/main/jakarta.jdt/org.eclipse.lsp4jakarta.jdt.core/plugin.xml from LSP4Jakarta:

<codeAction kind="quickfix"
                  targetDiagnostic="jakarta-annotations#PreDestroyStatic"
                  class="org.eclipse.lsp4jakarta.jdt.internal.annotations.RemoveStaticModifierQuickFix" />

Should add an equivalent binding in LTI plugin.xml for RemoveStaticModifierQuickFix.

Also see: image

One of the quick fix resolutions for this diagnostic should be to remove the static modifier from the method.

mrglavas commented 1 month ago

Resolved by https://github.com/OpenLiberty/liberty-tools-intellij/pull/778.