OpenLiberty / liberty-tools-intellij

IntelliJ IDEA extension for Liberty
https://plugins.jetbrains.com/plugin/14856-open-liberty-tools
Eclipse Public License 2.0
12 stars 24 forks source link

IntelliJ 2024.2: ProcessCanceledException class hierarchy changed. Resolve issues that arise from this API change. #767

Open mrglavas opened 4 months ago

mrglavas commented 4 months ago

Change in IntelliJ 2024.2 https://github.com/JetBrains/intellij-community/commit/12e78f18d6352502c7cc942dc677f02bb9b8b257#diff-53953a080bfbb7f3d529336a7318cfde6b06098f5fbb136f7c58c3fad831f500 See resolution in LSP4iJ: https://github.com/redhat-developer/lsp4ij/pull/293.

LTI has multiple places with multi catch of CancellationException and ProcessCanceledException and will face the same problem.

LSP4iJ compilation errors that occurred with IntelliJ 2024.2: image

vaisakhkannan commented 1 month ago

I haven't found the exact usage of the following in our code. catch (CancellationException | ProcessCanceledException e)

I found usages of the following catch (IndexNotReadyException | ProcessCanceledException | CancellationException e)

I have made Fixes to the above occurrences.

mrglavas commented 1 month ago

@vaisakhkannan I've moved this back to parked. We're not targeting IntelliJ 2024.2 for 24.0.8. Will revisit when we do move up to 2024.2.