Include RemoveFinalModifierQuickFix for resolving @Entity diagnostics and update unit tests.

OpenLiberty / liberty-tools-intellij

IntelliJ IDEA extension for Liberty

https://plugins.jetbrains.com/plugin/14856-open-liberty-tools

Eclipse Public License 2.0

12 stars 24 forks source link

Include RemoveFinalModifierQuickFix for resolving @Entity diagnostics and update unit tests. #773

Closed mrglavas closed 4 months ago

mrglavas commented 4 months ago

Resolves https://github.com/OpenLiberty/liberty-tools-intellij/issues/765 by including the missing quick fixes for removing the final modifier and completing enablement of the relevant unit test.

mrglavas commented 4 months ago

I am not sure if it is related to the changes here, but the Mac test failures look different than the ones we have been seeing.

The Mac failures look unrelated but I haven't seen (some of) them before either. I'm going to rerun the job. Certainly these UI tests are not reliably repeatable. The Linux build magically passed. There was nothing in the previous PR that would have caused the Linux failures and nothing in this PR that would have resolved them.

TrevCraw commented 4 months ago

Seeing similar test failures in main, so we can be certain that the issues did not originate from this PR.