search

OpenLiberty / liberty-tools-intellij

IntelliJ IDEA extension for Liberty
https://plugins.jetbrains.com/plugin/14856-open-liberty-tools
Eclipse Public License 2.0
11 stars 20 forks source link

Quick fix option is not working for Microprofile quickfix #775

Closed aparnamichael closed 3 weeks ago

aparnamichael commented 1 month ago

We are getting diagnostics and quickfix, when we remove @liveness annotation. But when we select a quick fix option, fix is not coming in the file. Due to this UI automated test is failing. test name - testMPQuickFixInJavaFile() Redhat LSP4IJ version - 0.0.1-20240518-012816

https://github.com/OpenLiberty/liberty-tools-intellij/assets/114654953/f2f3c1f3-b3d1-4d89-9eaa-114522150fe0

aparnamichael commented 3 weeks ago

There is a change in the resolvecodeaction method in the QuarkusLanguageClient.java file. (used JSONUtils from LSP4IJ) Commit link : https://github.com/redhat-developer/intellij-quarkus/commit/0d3437ea656f66e2bd71d0b25b77ab0d224b1e42#diff-1c090f2e6f8d11299[…]f7d2d0f37597479d04a0e3 I made the same change in resolvecodeaction method in our MicroprofileLanguageClient.java. Now Mp quickfix is working.

angelozerr commented 3 weeks ago

@aparnamichael can we close https://github.com/redhat-developer/lsp4ij/issues/294 ?

TrevCraw commented 3 weeks ago

@angelozerr that is unrelated to this closed issue