Closed yeekangc closed 1 year ago
Broke down the original into:
Other capabilities like below will be tracked via separate issues (epics):
@yeekangc - should we rename this an "early release" feature/issue so we can link it to a distinct UFO from the ultimate final release?
I think we want to target:
but not necessarily the Jakarta LS project (which is not as far along as MP LS).
I created #21055 to track the "early release", @scottkurz.
UFO Socialization Part 1 - October 14, 2022
Presenter: Scott Kurz
Notes:
Page 21
Page 31
Liberty
rather than Liberty Tools
Page 33
Start…
to understand the difference between Start and Start… ? Discussed that this is a standard UI pattern to use ...
to show configuration dialog will be displayed. Page 34
Debug As
in the MVP - Concerned that this pattern is expected? Revisit if Debug As is required for MVP.Debug As
even if it requires a Run first. Page 38
Another couple comments from after:
I don't think the user story should say "Users". It should be specific like "Day 2 Operator" or "DevOps Developer" or whatever is appropriate (maybe more than one). Generic "Users" doesn't help understanding of when and why they're using the tools to configure the Liberty server.
From the Friday 10/21/22 UFO review: Slide 30 Consider adding a button to reset parameters to default Rename "Main" tab I asked about using the terms Start vs run ? Alasdair noted we’re not calling Start goal, we’re calling dev mode
Slide 38 Create icon for mvn instead of m2
Slide 40 Standard eclipse run config dialog is labeled JRE, but we require a JDK. Consider some way to indicate the need for JDK vs JRE
Slide 45 Typo "Lanaguage" should be "Language"
Slide 50 Update slide to mention config prefs
Slide 57: I asked about the ability to upgrade (vs new install) of plugin. Scott to check on whether data updated to allow applying update to 04 release
Slide 62 Typo “issues” should be “issued”
Slide 63 typo “withing” should be “within”
General suggestion from Alasdair: When in Tools and you open test results, it would be nice to open them in JUnit view
In slide 43, I wrote the mmod text the user must add as if it were the suggestion generated by Liberty Tools Eclipse.
I've addressed all comments with UFO updates and/or issues in our repo: https://github.com/OpenLiberty/liberty-tools-eclipse/issues
@scottkurz, please post link to latest UFO (with all feedback incorporated) and put in a "Design Approval Request" as soon as ready. Thanks.
Updated UFO at previous link: https://ibm.box.com/s/curdb0qg6su1jgtn4yhlf95m49hhkuu2
Let me highlight the updates from earlier rounds of review:
*.xml
to this editor.Besides that, let me make a few more notes:
Additional update:
@scottkurz you are right that I'm not bought into having a "Run Stop" option in the UI, but as long as we can continue that discussion in the future I'm ok to approve despite not liking the current design.
(Deleted earlier template info and edited the original comment to include info based on the latest feature template)
@scottkurz the above looks to be using an extremely outdated template from somewhere. Please update using the latest feature template: https://github.com/OpenLiberty/open-liberty/issues/new?assignees=&labels=Epic&template=feature.md&title=Open+Liberty+Feature+Template
@mbroz2 - this isn't a runtime feature but a devex one. We've been talking about coming up with a DevEx template but it seemed like this old template was just as good to work from .
@scottkurz I would still recommend basing any new templates off of the latest version of the open-liberty feature template (and updating the one in this issue). Many things you have above are incorrect... for example, various focals like a11y and even WDT.
Closing as complete
@scottkurz @yeekangc this feature was closed but is missing the other focal approvals.
@malincoln For these non-runtime features, like this Eclipse tooling feature, we haven't generally been adding the full set of focal approvals or checking off the full template's checklist. We have in this case followed a subset of the process and done more than just the UFO by adding the SVT and ID approvals.
Description
Enable developers that use Eclipse IDE as their IDE to pull down and install from its marketplace an integrated set of tools to code/build/test/debug their Java applications on top of Liberty easily and iterative fast (rapid inner loop) using APIs like Jakarta EE and MicroProfile.
Solution involves creating an Eclipse IDE plugin for Liberty that enables developers to easily create and develop cloud-native Java applications with Liberty in Eclipse IDE.
Plugin should include:
Integration with dev mode (e.g. to start/stop Liberty and make iterative changes with dev mode)
Assistance to edit Liberty configuration files (via #14054)
Pull down language servers (e.g. Language Servers for Jakarta EE and MicroProfile) that provide coding assistance for programming models supported by Liberty that are currently available
Note on Checklist for non-runtime feature
Took some liberties in deleting, ignoring, marking N/A sections that did not seem to apply to a tooling (rather than a runtime) deliverable, while realizing this isn't the only way to interpret or map the runtime process onto tooling. Still left some aspects like the ID and SVT focal approval, and of course the whole UFO process.
Documents
Aha: Externally raised RFE - N/A
UFO: https://ibm.box.com/s/curdb0qg6su1jgtn4yhlf95m49hhkuu2
FTS: https://github.com/OpenLiberty/liberty-tools-eclipse/issues/426
Beta Blog: https://github.com/OpenLiberty/blogs/issues/2796
GA Blog: https://github.com/OpenLiberty/blogs/issues/3184
Design
Design Preliminaries
Design
FAT Documentation
Legal and Translation
In order to avoid last minute blockers and significant disruptions to the feature, the legal items need to be done as early in the feature process as possible, either in design or as early into the development as possible. Similarly, translation is to be done concurrently with development. Both MUST be completed before Beta or GA is requested.
Legal (Complete before Feature Complete Date)
Translation (Complete 1 week before Feature Complete Date)
Innovation (Complete 1 week before Feature Complete Date)
[X] Consider whether any aspects of the feature may be patentable. If any identified, disclosures have been submitted.
Beta
In order to facilitate early feedback from users, all new features and functionality should first be released as part of a beta release.
Beta Code
GA
A feature is ready to GA after it is Feature Complete and has obtained all necessary Focal Point Approvals.
Feature Complete
Focal Point Approvals (Complete by Feature Complete Date)
Design Approved Features
focalApproved:svt
.GA Blog (Complete by Feature Complete Date)
[X] GA Blog issue created and populated
Other Deliverables
[X] Standalone Feature Blog Post N/A
[X] OL Guides N/A
[X] Dev Experience Developer Experience & Tools work is complete or N/A. (OpenLiberty/dev-experience-assessment)