search

OpenLiberty / open-liberty

Open Liberty is a highly composable, fast to start, dynamic application server runtime environment
https://openliberty.io
Eclipse Public License 2.0
1.15k stars 592 forks source link

favicon.ico content type is text/plain #11570

Open NottyCode opened 4 years ago

NottyCode commented 4 years ago

Describe the bug When Liberty serves up the favicon.ico file it sets a content-type of text/plain which isn't correct. It should be image/x-icon. This doesn't break things in the usage I've seen, but it still seems wrong.

Steps to Reproduce Go to https://openliberty.io using a web browser with the developer tools open. Look at the network view at favicon.ico and look at the content type.

Expected behavior Content-Type should be image/x-icon

Diagnostic information:

pnicolucci commented 4 years ago

Looking at the source of the page I see: <link rel="icon" type="image/x-icon" href="/favicon.ico"> perhaps liberty is defaulting back to text/plain for some reason when serving the response.