SameSite=None incompatible Clients

[pnicolucci]

Description

SameSite Cookie High-Level Overview:

• This SameSite attribute restricts a browser from sending a cookie in various requests.

• In Open Liberty, SameSite is enabled via the server.xml.

  There are three types of SameSite attributes:

  • Strict
    • The cookie is only sent with "same-site" requests. The cookie is only sent by the web browser if the site for the cookie matches the site in the address bar for example.
  • Lax
    • The cookie is sent with both "same-site" and "cross-site" top-level navigation requests. Clicking a link, for example.
  • None
    • The cookie is sent with both "same-site" and "cross-site" requests. The cookie is sent by the web browser for third-party contexts, embedded content, for example. This is the problematic attribute and is discussed further below.

Note: Cookies defined as having a SameSite attribute value of None require that the Secure attribute is also used. The code above HTTP transport should add the Secure attribute, but Open Liberty adds this attribute if it's not already there. (More on this later)

More detailed information can be read here: https://openliberty.io/blog/2020/03/25/set-samesite-attribute-cookies-liberty.html

Problem: Some user agents are known to be incompatible with the SameSite=None attribute. [1]

• Versions of Chrome from Chrome 51 to Chrome 66 (inclusive on both ends)
• Versions of UC Browser on Android before version 12.13.2. Older versions will reject a cookie with SameSite=None.
• Versions of Safari and embedded browsers on MacOS 10.14 and all browsers on iOS 12. (here, SameSite=None is treated as Strict)

Current Available Documentation:

• Some out-of-date browsers misinterpret SameSite=None or ignore Cookies set with SameSite=None. [2]
• IBM HTTP Server samesite-global.conf lists pattern matching [3]

Current Workarounds (for not sending SameSite=None):

• None for Session/Security defined cookies by Open Liberty
• Application-defined cookies should be addressed by the application.

Serviceability Considerations:

• Should be straightforward, given the explanations here.

Proposed Solution:

• A regular expression is used to identify if the user-agent is incompatible with the SameSite=None attribute
• These regular expressions will not be configurable, and therefore hard-coded.
• If an incompatible user agent is found, then Open Liberty won't send SameSite=None.
• As mentioned, SameSite=None requires the secure attribute. While it could be removed, our current solution retains this attribute.
• The incompatible client search occurs in com.ibm.ws.http.channel.internal.HttpBaseMessageImpl.marshallCookies method, just before the response is sent out.
• This change affects all cookies: Session-defined cookies by Open Liberty, Security-defined cookies by Open Liberty, and Application-defined cookies.
• No additional configuration is needed.

Testing (#19887)

• Unit Testing to test the compatibility of several browsers: Chrome Versions 51 - 66, UC Browser, iOS 12 Browsers, Safari MacOS browsers

1) https://www.chromium.org/updates/same-site/incompatible-clients 2) https://www.ibm.com/support/pages/browser-changes-samesite-cookie-handling-and-websphere-application-server 3) http://publib.boulder.ibm.com/httpserv/ihsdiag/_static/samesite-global.conf

---

Documents

When available, add links to required feature documents. Use "N/A" to mark particular documents which are not required by the feature.

• Externally raised requests for enhancements:

  • Aha: Link to the Aha idea (also add a link to this issue in the Aha idea)
  • Feature owner adds label Aha idea
  • Open Liberty Feature Request: Link to the OL GH issue (also add a link to this issue in the Feature Request GH issue)
  • Feature owner adds label Requested feature

• UFO: Link to Upcoming Feature Overview document

  • Upload the feature UFO to Box and set the link to be publicly accessible, with a long expiration (10 years)
  • Click "Share" > select "People with link" > click "Link Settings" > under "Link Expiration" select "Disable Shared Link on" > set an expiration date ~10 years into the future
  • If you lack permissions, contact OpenLiberty/release-architect

• FTS: https://github.com/OpenLiberty/open-liberty/issues/24902

• Beta Blog(s): https://github.com/OpenLiberty/open-liberty/issues/29331

• GA Blog: https://github.com/OpenLiberty/open-liberty/issues/30255

• ---

  Process Overview

• Prioritization

• Design

• Implementation

• Legal and Translation

• Beta

• GA

  • Focal Point Approvals

• Other Deliverables

General Instructions

The process steps occur roughly in the order as presented. Process steps occasionally overlap.

Each process step has a number of tasks which must be completed or must be marked as not applicable ("N/A").

Unless otherwise indicated, the tasks are the responsibility of the feature owner or a delegate of the feature owner.

If you need assistance, reach out to the OpenLiberty/release-architect.

Important: Labels are used to trigger particular steps and must be added as indicated.

---

Prioritization (Complete Before Development Starts)

The OpenLiberty/chief-architect and area leads are responsible for prioritizing the features and determining which features are being actively worked on.

Prioritization

• [X] Feature owner adds label Prioritization - Requested

  • This puts the feature on the radar of the OpenLiberty/chief-architect and OpenLiberty/project-manager. They are responsible for querying for new features that need to be prioritized.

• [X] OpenLiberty/project-manager adds feature to the "New" column of the Open Liberty project board

• [X] Priority assigned

  • Attend the Liberty Backlog Prioritization meeting
  • Prioritization - Requested label removed (OpenLiberty/project-manager or feature owner)

• ---

  Design (Complete Before Development Starts)

Design preliminaries determine whether a formal design, which will be provided by an Upcoming Feature Overview (UFO) document, must be created and reviewed. A formal design is required if the feature requires any of the following: UI, Serviceability, SVT, Performance testing, or non-trivial documentation/ID. Furthermore, each identified item places a blocking requirement on another team so it must be identified early in the process. The feature owner may check-off the item if they know it doesn't apply, but otherwise they should work with the focal point to determine what work, if any, will be necessary and make them aware of it.

Design Preliminaries

• [X] UI requirements identified, or N/A. (Feature owner and UI focal point)
• [x] Accessibility requirements identified, or N/A. (Feature owner and Accessibility focal point)
• [x] ID requirements identified, or N/A. (Feature owner and ID focal point)
  • Refer to Documenting Open Liberty.
  • Feature owner adds label ID Required, if non-trivial documentation needs to be created by the ID team.
  • ID adds label ID Required - Trivial, if no design will be performed and only trivial ID updates are needed.
• [x] Serviceability requirements identified, or N/A. (Feature owner and Serviceability focal point)
• [x] SVT requirements identified, or N/A. (Feature owner and SVT focal point)
• [x] Performance testing requirements identified, or N/A. (Feature owner and Performance focal point)

Design

• [ ] POC Design / UFO review requested.
  • Feature owner adds label Design Review Request
• [ ] POC Design / UFO review scheduled.
  • Follow the instructions in POC-Forum repo
• [ ] POC Design / UFO review completed.
• [ ] POC / UFO Review follow-ons completed.
• [ ] POC Design / UFO approval requested.
  • Feature owner adds label Design Approval Request
• [ ] Design / UFO approved. (OpenLiberty/chief-architect) or N/A
  • (OpenLiberty/chief-architect) adds label Design Approved
  • Add the public link to the UFO in Box to the Documents section.
  • The UFO must always accurately reflect the final implementation of the feature. Any changes must be first approved. Afterwards, update the UFO by creating a copy of the original approved slide(s) at the end of the deck and prepend "OLD" to the title(s). A single updated copy of the slide(s) should take the original's place, and have its title(s) prepended with "UPDATED".

No Design

• [X] No Design requested.
  • Feature owner adds label No Design Approval Request
• [X] No Design / No UFO approved. (OpenLiberty/chief-architect) or N/A
  • Approver adds label No Design Approved
• [X] Feature / Capability stabilization or discontinuation or N/A
  • Feature owner adds label Product Management Approval Request and notifies OpenLiberty/product-management
  • Approver adds label Product Management Approved (OpenLiberty/product-management)
  • Note: For stabilized, superseded, and discontinued feature/capability, skip the Beta section of the template (you may delete it). Otherwise, proceed as normal.

FAT Documentation

• [X] "Feature Test Summary" child task created

  • Use the Feature Test Summary Template
  • Add FTS issue link to the Documents section.

• ---

  Implementation

A feature must be prioritized before any implementation work may begin to be delivered (inaccessible/no-ship). However, a design focused approach should still be applied to features, and developers should think about the feature design prior to writing and delivering any code.
Besides being prioritized, a feature must also be socialized (or No Design Approved) before any beta code may be delivered. All new Liberty content must be inaccessible in our GA releases until it is Feature Complete by either marking it kind=noship or beta fencing it.
Code may not GA until this feature has obtained the Design Approved or No Design Approved label, along with all other tasks outlined in the GA section.

Feature Development Begins

• [X] Add the In Progress label

Legal and Translation

In order to avoid last minute blockers and significant disruptions to the feature, the legal items need to be done as early in the feature process as possible, either in design or as early into the development as possible. Similarly, translation is to be done concurrently with development. All items below MUST be completed before beta & GA is requested.

Innovation (Complete 1 week before Beta & GA Feature Complete Date)

• [X] Consider whether any aspects of the feature may be patentable. If any identified, disclosures have been submitted.

Legal (Complete before Beta & GA Feature Complete Date)

• [X] Changed or new open source libraries are cleared and approved, or N/A. (Legal Release Services/Cass Tucker/Release PM).

Translation (Complete by Beta & GA Feature Complete Date)

• [x] PII (Program Integrated Information) updates are merged (i.e. all English strings due for translation have been delivered), or N/A.

• ---

  Beta

In order to facilitate early feedback from users, all new features and functionality should first be released as part of a beta release.

Beta Code

• [x] Beta fence the functionality
  • E.g. kind=beta, ibm:beta, ProductInfo.getBetaEdition()
• [x] Beta development complete and feature ready for inclusion in a beta release
  • Add label target:beta and the appropriate target:YY00X-beta (where YY00X is the targeted beta version) to the feature issue.
  • Note: This is expected to be done only once, for the initial beta that includes this feature. You do not need to add a target:YY00(X+1)-beta, target:YY00(X+2)-beta, etc. label for each additional beta that includes this feature.
• [x] Feature delivered into beta
  • (OpenLiberty/release-manager) adds label release:YY00X-beta (where YY00X is the first beta version that included the functionality).

Beta Blog (Complete by beta eGA)

• [x] Beta blog issue created and populated using the Open Liberty BETA blog post template.

  • Add a link to the beta blog issue in the Documents section.
  • Note: This is for inclusion into the overall beta release blog post. If, in addition, you'd also like to create a dedicated blog post about your feature, then follow the "Standalone Feature Blog Post" instructions under the Other Deliverables section.
  • A feature may have multiple beta blogs associated with it. This is especially useful for features that are continuously adding functionality each release and want to advertise what is new since the previous beta.
  • Each beta blog issue should have the appropriate target:YY00X-beta label added to it.
  • Include each beta blog issue in the Documents section.

• ---

  GA

A feature is ready to GA after it is Feature Complete and has obtained all necessary Focal Point Approvals.

Feature Complete

• [x] Feature implementation and tests completed.
  • [x] All PRs are merged.
  • [x] All related/child issues are closed.
  • [x] All stop ship issues are completed.
• [x] Legal: all necessary approvals granted.
• [x] Innovation: IP identified and any applicable disclosures submitted
• [x] Translation: Feature may only proceed to GA if it has either Translation - Not Required, Translation - Complete, or Translation - Missing label
  • If the feature does not have anything that required translation, the feature owner adds the label Translation - Not Required.
  • If all translation has been delivered to release branch, feature owner adds label Translation - Complete.
  • If missing translation does not cause a break in functionality, nor a security or production outage risk, feature owner adds label Translation - Missing.
  • Once all missing translations are delivered, the Translation - Missing label is replaced with Translation - Complete.
  • If missing translation could cause a break in functionality or a security or production outage risk, feature owner adds the Translation - Blocked label.
  • Features with Translation - Blocked may NOT proceed to GA until the label has been replaced with either Translation - Missing or Translation - Complete.
  • For further guidance, contact Globalization focal point or the Release Architect.
• [x] GA development complete and feature ready for inclusion in a GA release
  • Add label target:ga and the appropriate target:YY00X (where YY00X is the targeted GA version).
  • Inclusion in a release requires the completion of all Focal Point Approvals.

Focal Point Approvals (Complete by Feature Complete Date)

These occur only after GA of this feature is requested (by adding a target:ga label). GA of this feature may not occur until all approvals are obtained.

All Features

• [x] APIs/Externals - Externals have been reviewed or N/A. (OpenLiberty/externals-approvers)
  • Approver adds label focalApproved:externals
• [x] Demo - Demo is scheduled for an upcoming EOI or N/A. (OpenLiberty/demo-approvers)
  • Add comment @OpenLiberty/demo-approvers Demo scheduled for EOI [Iteration Number] to this issue.
  • Approver adds label focalApproved:demo.
• [x] FAT - All Tests complete and running successfully in SOE or N/A. (OpenLiberty/fat-approvers)
  • Approver adds label focalApproved:fat.

Design Approved Features

• [ ] ID - Documentation is complete or N/A. (OpenLiberty/id-approvers)
  • Approver adds label focalApproved:id.

  • NOTE: If only trivial documentation changes are required, you may reach out to the ID Feature Focal to request a ID Required - Trivial label. Unlike features with regular ID requirement, those with ID Required - Trivial label do not have a hard requirement for a Design/UFO.

• [ ] InstantOn - InstantOn capable or N/A. (OpenLiberty/instantOn-approvers)
  • Approver adds label focalApproved:instantOn.
• [ ] Performance - Performance testing is complete or N/A. (OpenLiberty/performance-approvers)
  • Approver adds label focalApproved:performance.
• [ ] Serviceability - Serviceability has been addressed or N/A. (OpenLiberty/serviceability-approvers)
  • Approver adds label focalApproved:sve.
• [ ] STE - Skills Transfer Education chart deck is complete or N/A. (OpenLiberty/ste-approvers)
  • Approver adds label focalApproved:ste.
• [ ] SVT - System Verification Test is complete or N/A. (OpenLiberty/svt-approvers)
  • Approver adds label focalApproved:svt.

Remove Beta Fencing (Complete by Feature Complete Date)

• [x] Beta guards are removed, or N/A
  • Only after all necessary Focal Point Approvals have been granted.

GA Blog (Complete by Friday after GM)

• [x] GA Blog issue created and populated using the Open Liberty GA release blog post template.
  • Add a link to the GA Blog issue in the Documents section.
  • Note: This is for inclusion into the overall release blog post. If, in addition, you'd also like to create a dedicated blog post about your feature, then follow the "Standalone Feature Blog Post" instructions under the Other Deliverables section.

Post GM (Complete before GA)

• [ ] After confirming this feature has been included in the GM driver, feature owner closes this issue.

Post GA

• [ ] Remove the target:ga and target:YY00X labels, and add the appropriate release:YY00X. (OpenLiberty/release-manager)

• ---

  Other Deliverables

• [x] Standalone Feature Blog Post - A blog post specifically about your feature or N/A. (Feature owner and OpenLiberty/release-architect)

  • This should be strongly considered for larger or more prominent features.
  • Follow instructions in the blogs repo.

• [x] OL Guides - OL Guides assessment is complete or N/A. (OpenLiberty/guide-assessment)

• [x] Dev Experience - Developer Experience & Tools work is complete or N/A. (OpenLiberty/dev-experience-assessment)

• ---

[pnicolucci]

This feature is in progress but has been on hold due to the Jakarta EE10 and Netty work that our team is currently involved in. Once we complete the Jakarta EE10 work we will be able to focus on and close this feature out.

[pnicolucci]

I updated this issue to use the latest feature template.

[pnicolucci]

I talked with @yeekangc and he's in agreement that there is nothing to do for guides/dev experience for this epic.