FAT cases have been added to the webcontainer_fat bucket; these changes will also be ported to tWAS, so it is convenient to have these tests in webcontainer_fat since that bucket is largely common between tWAS and Liberty. Those FAT changes can be seen directly at https://github.ibm.com/websphere/WS-CD-Open/pull/22595
In general, those tests were updated to validate the new config available in #9808.
new test trustedHeaderOrigin_HostNameMatch validates trustedHeaderOrigin="<localHostName>"
new test trustedSensitiveHeaderOrigin_HostNameMatch_trustedHeaderOrigin_none validates:
trustedSensitiveHeaderOrigin="<localHostName>" and trustedHeaderOrigin="none"
new test trustedSensitiveHeaderOrigin_WildcardMatch_trustedHeaderOrigin_none validates:
trustedSensitiveHeaderOrigin="127.0.0.*" and trustedHeaderOrigin="none"
new test trustedSensitiveHeaderOrigin_none_trustedHeaderOrigin_invalid validates:
trustedSensitiveHeaderOrigin="none and trustedHeaderOrigin=invalid
new test trustedSensitiveHeaderOrigin_invalid_trustedHeaderOrigin_none validates:
trustedSensitiveHeaderOrigin=invalid and trustedHeaderOrigin="none"
In summary, these new tests (in addition to the existing tests) validate the following config cases:
wildcards in IP and hostnames
hostnames (validated with "localhost")
IPv6 formatting
2)
4 - We have delivered all automated testing we believe is needed for the golden paths of this feature and have good coverage of the error/outlying scenarios. While more testing of the error/outlying scenarios could be added we believe there is minimal risk here and the cost of providing these is considered higher than the benefit they would provide.
Bill provided confirmation that there are tests for comma-separated values, hostnames with leading wildcards, and IPv6 formatting for the relevant properties.
For #9809
1) These changes were first tested and extensively validated using unit tests. For those changes, see https://github.com/OpenLiberty/open-liberty/pull/14661/files#diff-89039d92ea2128b9cf7deaf36dffcde040d7928b75f6a03a8a3a3b23ab4356ac
FAT cases have been added to the
webcontainer_fat
bucket; these changes will also be ported to tWAS, so it is convenient to have these tests inwebcontainer_fat
since that bucket is largely common between tWAS and Liberty. Those FAT changes can be seen directly at https://github.ibm.com/websphere/WS-CD-Open/pull/22595In general, those tests were updated to validate the new config available in #9808.
trustedHeaderOrigin_HostNameMatch
validatestrustedHeaderOrigin="<localHostName>"
trustedSensitiveHeaderOrigin_HostNameMatch_trustedHeaderOrigin_none
validates:trustedSensitiveHeaderOrigin="<localHostName>"
andtrustedHeaderOrigin="none"
trustedSensitiveHeaderOrigin_WildcardMatch_trustedHeaderOrigin_none
validates:trustedSensitiveHeaderOrigin="127.0.0.*"
andtrustedHeaderOrigin="none"
trustedSensitiveHeaderOrigin_none_trustedHeaderOrigin_invalid
validates:trustedSensitiveHeaderOrigin="none
andtrustedHeaderOrigin=invalid
trustedSensitiveHeaderOrigin_invalid_trustedHeaderOrigin_none
validates:trustedSensitiveHeaderOrigin=invalid
andtrustedHeaderOrigin="none"
In summary, these new tests (in addition to the existing tests) validate the following config cases:
2) 4 - We have delivered all automated testing we believe is needed for the golden paths of this feature and have good coverage of the error/outlying scenarios. While more testing of the error/outlying scenarios could be added we believe there is minimal risk here and the cost of providing these is considered higher than the benefit they would provide.