OpenLiberty / open-liberty

Open Liberty is a highly composable, fast to start, dynamic application server runtime environment
https://openliberty.io
Eclipse Public License 2.0
1.16k stars 599 forks source link

Feature Test Summary for 9809 trustedHeaderOrigin config improvements #15581

Closed wtlucy closed 3 years ago

wtlucy commented 3 years ago

For #9809

1) These changes were first tested and extensively validated using unit tests. For those changes, see https://github.com/OpenLiberty/open-liberty/pull/14661/files#diff-89039d92ea2128b9cf7deaf36dffcde040d7928b75f6a03a8a3a3b23ab4356ac

FAT cases have been added to the webcontainer_fat bucket; these changes will also be ported to tWAS, so it is convenient to have these tests in webcontainer_fat since that bucket is largely common between tWAS and Liberty. Those FAT changes can be seen directly at https://github.ibm.com/websphere/WS-CD-Open/pull/22595

In general, those tests were updated to validate the new config available in #9808.

In summary, these new tests (in addition to the existing tests) validate the following config cases:

2) 4 - We have delivered all automated testing we believe is needed for the golden paths of this feature and have good coverage of the error/outlying scenarios. While more testing of the error/outlying scenarios could be added we believe there is minimal risk here and the cost of providing these is considered higher than the benefit they would provide.

ayoho commented 3 years ago

Bill provided confirmation that there are tests for comma-separated values, hostnames with leading wildcards, and IPv6 formatting for the relevant properties.

In that case, the coverage looks good to me. 👍