search

OpenLiberty / open-liberty

Open Liberty is a highly composable, fast to start, dynamic application server runtime environment
https://openliberty.io
Eclipse Public License 2.0
1.16k stars 597 forks source link

Fix some HTTP2 compliance issues #18235

Open Thihup opened 3 years ago

Thihup commented 3 years ago

Describe the bug Running a conformance testing tool for the HTTP/2 implementation, I've found that some items fail. The tool used to test is this one: https://github.com/summerwind/h2spec

Steps to Reproduce

./h2spec -p 9080 --strict
147 tests, 135 passed, 0 skipped, 12 failed

Expected behavior All tests should pass

Diagnostic information:

Additional context I've noticed that running Jenkins with HTTP2 enabled cause the program to behave very strangely, and if I use the DevTools with disable-cache it kind of works. Using HTTP/1.1 seems to work great. This is why I'm opening this issue, to see if any of the failed tests can fix the use of HTTP2 in Jenkins.

wtlucy commented 3 years ago

I'm familiar with h2spec - we've run the tool in the past for internal testing. We'll review the failures to see if there are any fixes we need to make (based on our interpretation of the RFC)

@Thihup can you give us more info about your Jenkins config, and if possible steps for reproducing the strange/bad behavior you see?

Thihup commented 3 years ago

I'll try to create a reproducer