Add Total Connections to Connection Pool stats

[NottyCode]

Description of the high level feature, including any external spec links:

The connection pool stats mbean doesn't expose the max pool size which makes it harder to know when the pool is close to or has exhausted the connections.

Design,

Adding MaxConnectionsLimit to the pmi data. (Note: MaxConnectionCount was changed to MaxConnectionsLimit)

Current pmi data in jconsole includes this and the new value

WebSphere ConnectionPoolStats jdbc/ds Attributes FreeConnectionCount DestroyCount WaitTime WaitTimeDetails CreateCount InUseTimeDetails ManagedConnectionCount ConnectionHandleCount InUseTime

                      MaxConnectionsLimit     (new pmi value)

With the maximum pool size exposed under attribute MaxConnectionsLimit, customers will be able to see when they are close or at maximum pool size in jconsole or by using other tools.

---

When complete & mandatory, add links to the UFO (Upcoming Feature Overview) document, FTS (Feature Test Summary), blogs post issues(s), and Aha (externally raised RFEs):

• UFO:

• FTS:

• Beta Blog Post (if applicable):

• Blog Post:

• Aha:

  • Also, add a comment into the Aha idea linking to this issue.

• ---

  List of Steps to complete or get approvals / sign-offs for Onboarding to the Liberty release (GM date)

Instructions:

• Do the actions below and mark them complete in the checklist when they are done.
• Make sure all feature readiness approvers put the appropriate tag on the epic to indicate their approval.

Design

Before Development Starts or 8 weeks before Onboarding

• [x] POC Design / UFO Review Scheduled (David Chang) or N/A.
• [x] POC Design / UFO Reviewed (Feature Owner) or N/A.
• [x] Complete any follow-ons from the POC Review.
• [x] Design / UFO Approval (Alasdair Nottingham) or N/A.
• [x] No Design / No UFO Approval (Alasdair Nottingham) or N/A.
  • Note: Design is required if any of the following apply: SVT or Performance testing, new UI, Servicibility considerations, significant documentation changes
• [x] ID Requirements identified (Documenting Open Liberty). (Epic owner / Feature owner with ID focal point)
  • Note: If only trivial documentation changes are required, you may reach out to the ID Feature Focal to request a ID Required - Trivial label. Unlike features with regular ID requirement, those with ID Required - Trivial label do not have a hard requirement for a Design/UFO.
• [x] SVT Requirements identified. (Epic owner / Feature owner with SVT focal point)
• [x] Create a child task of this epic entitled "Feature Test Summary" via this template. Add the link in above.

Before proceeding to any items below (active development), this feature MUST be prioritized on the backlog, and have been socialized (e.g., UFO Review). Follow the Feature and UFO Approval Process.

Development

When active development has begun

• [x] Add the "In Progress" label to this issue.

Beta

If your feature, or portions of it, are going to be included in a beta
Before Onboarding the beta

• [x] Beta Fence the functionality (kind=beta, ibm:beta, ProductInfo.getBetaEdition())

1 week before beta GA

• [x] Create, populate, and link to the Beta blog post issue

Legal

3 weeks before Onboarding

• [x] Identify all open source libraries that are changing or are new. Work with Legal Release Services (Cass Tucker or Release PM) to get open source cleared and approved. Or N/A. (Epic Owner). New or changed open source impacts license and Certificate of Originality.

Translation

3 weeks before Onboarding

• [x] All new or changed PII messages are checked into the integration branch, before the last translation shipment out. (Epic Owner)

Feature Complete

2 weeks before Onboarding

• [x] Implementation complete. (Epic owner / Feature owner)
• [x] All function tests complete. Ready for FAT Approval. (Epic owner / Feature owner)
• [x] Review all known issues for Stop Ship. (Epic owner / Feature owner / PM)

Focal Point Approvals

2 to 1 week before Onboarding

You MUST have the Design Approved or No Design Approved label before requesting focal point approvals.

All features (both "Design Approved" and "No Design Approved")

• [ ] FAT - (OpenLiberty/fat-approvers). SOE FATS are running successfully or N/A . Approver adds label focalApproved:fat to the Epic in Github.
• [ ] Demo - (Tom Evans or Chuck Bridgham). Demo is scheduled for an upcoming EOI. Approver adds label focalApproved:demo to the Epic in Github.
• [ ] Globalization (Sam Wong - Liberty / Simy Cheeran - tWAS). Translation is complete or N/A. TVT - complete or N/A. Approver adds label focalApproved:globalization to the Epic in Github.

"Design Approved" features

• [ ] Accessibility - (Steven Zvonek). Accessibility testing is complete or N/A. Approver adds label focalApproved:accessibility to the Epic in Github.
• [ ] ID - (Karen Deen). Documentation work is complete or N/A . Approver adds label focalApproved:id to the Epic in Github.
  • Note: If only trivial documentation changes are required, you may reach out to the ID Feature Focal to request a ID Required - Trivial label. Unlike features with regular ID requirement, those with ID Required - Trivial label do not have a hard requirement for a Design/UFO.
• [ ] Performance - (Jared Anderson). Performance testing is complete with no high severity defects or N/A . Approver adds label focalApproved:performance to the Epic in Github.
• [ ] Serviceability - (Don Bourne). Serviceability has been addressed.
• [ ] STE - (Swati Kasundra). STE chart deck is complete or N/A . Approver adds label focalApproved:ste to the Epic in Github.
• [ ] SVT - (Brian Hanczaryk - APS). SVT is complete or N/A . Approver adds label focalApproved:svt to the Epic in Github.

Ready for GA

1 week before Onboarding

• [ ] No Stop Ship issues for the feature. (Epic owner / Feature owner / Release PM)
• [ ] Ship Readiness Review and Release Notes completed (Epic owner / Feature owner / Release PM)
• [ ] Github Epic and Epic's issues are closed / complete. All PRs are committed to the release branch. (Epic owner / Feature owner / Backlog Subtribe PM)

1 week before GA

• [ ] Create, populate, and link to the Blog post issue

Other deliverbles

• [ ] OL Guides - (Yee-Kang Chang). Assessment for OL Guides is complete or N/A.
• [ ] WDT - (Leonard Theivendra). WDT work complete or N/A.
• [ ] Blog - (Laura Cowen) Blog article writeup (Epic owner / Feature owner / Laura Cowen)

[NottyCode]

@jmstephensgit Can you update the description with the design please?

[NottyCode]

Removing No Design Approval Request until the description is updated with the design.

[jmstephensgit]

Here is a pull that contains changes that may be used in the implementation of this function. https://github.com/OpenLiberty/open-liberty/pull/24965

Most of the code is simple with the main work allowing for dynamic updates of maximum connections.

[jmstephensgit]

Changed MaxConnectionCount to MaxConnectionsLimit. During the design it was thought the statistic object was going to be a Counter object, but during implementation it was changed to a Gauge object. Keeping the name with Count does not make as much sense and during code review we decided to change the name.

[jmstephensgit]

Feature test summary - #24984