Identify WOLA (Z)FATS and run them successfully

[hutchig]

https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_FKabUJo1EeyylMvVD7B-oA built successfully but did not run the FATs due to infrastructure problems it has been resubmitted as https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/__sQSwJ4UEey_qP_JrfMVIQ

[hutchig]

zfats='com.ibm.ws.jbatch.wola_zfat,com.ibm.ws.jbatch.security_zfat,com.ibm.ws.jbatch_zfat,com.ibm.ws.zos.channel.wola_zfat,com.ibm.ws.zos.connect.wola_zfat,com.ibm.ws.zos.ola.ims.svt_zfat,com.ibm.ws.zos.ola_zfat,com.ibm.ws.zos.ola.alcs_zfat,'

[hutchig]

• [x] clean com.ibm.ws.jbatch.wola_zfat,
• [x] clean com.ibm.ws.jbatch.security_zfat,
• [x] clean com.ibm.ws.jbatch_zfat,
• [ ] clean com.ibm.ws.zos.channel.wola_zfat,
• [x] clean com.ibm.ws.zos.connect.wola_zfat,
• [x] clean com.ibm.ws.zos.ola.ims.svt_zfat,
• [x] clean com.ibm.ws.zos.ola_zfat,
• [ ] clean com.ibm.ws.zos.ola.restart_zfat,
• [ ] clean com.ibm.ws.zos.ola.alcs_zfat

[hutchig]

https://wasrtc.hursley.ibm.com:9443/jazz/web/projects/WS-CD#action=com.ibm.team.build.viewResult&id=_hanVUO5aEeyVkLDPEXw2dw&tab=com.ibm.team.build.web.ui.internal.editors.result.test.TestProvider

[hutchig]

IMS testing is via ims.svt.FATTest:

(I can also see runs of this that fail with java.io.FileNotFoundException: File '/WebSphere/Misc/jazz_build/jbe_zrock157/jazz/buildsystem/buildengine/eclipse/build/dev/image/output/wlp/dev/api/ibm/zos/bboaapip.include' does not exist in an unchanged (basically main branch) ...and there are lots of IMS AND CICS testing in com.ibm.ws.zos.ola_zfat e.g https://wasrtc.hursley.ibm.com:9443/jazz/web/projects/WS-CD#action=com.ibm.team.build.viewResult&id=_92LlYPLsEeyYXLZn0n3zUg&tab=com.ibm.team.build.web.ui.internal.editors.result.overview.OverviewPage

[hutchig]

Only channel and alcs FAT buckets remain to verify as 100% working

[hutchig]

The alcs specific build at https://wasrtc.hursley.ibm.com:9443/jazz/web/projects/WS-CD#action=com.ibm.team.build.viewResult&id=_SeprIPCxEeyYXLZn0n3zUg&tab=com.ibm.team.build.web.ui.internal.editors.result.properties.PropertiesProvider with

fat.buckets.to.run	com.ibm.ws.zos.ola.alcs_zfat

Has appearred to run 0 tests. Think I found why!: ~/libertyGit/WS-CD-Open/dev/com.ibm.ws.zos.ola.alcs_zfat $ ls build publish build-ztest.xml.disabled

[hutchig]

Ditto for channel FAT: $ cd com.ibm.ws.zos.channel.wola_zfat ~/libertyGit/WS-CD-Open/dev/com.ibm.ws.zos.channel.wola_zfat $ ls build publish build-ztest.xml.disabled test-applications fat test-bundles

[hutchig]

alcs and channel ZFAT runs requested at https://wasrtc.hursley.ibm.com:9443/jazz/web/projects/WS-CD#action=com.ibm.team.build.viewDefinition&id=_JWdEUD7dEemKFI0xRbWJ_w https://wasrtc.hursley.ibm.com:9443/jazz/web/projects/WS-CD#action=com.ibm.team.build.viewResult&id=_rVJ18PFGEeyYXLZn0n3zUg

[hutchig]

As per https://wasrtc.hursley.ibm.com:9443/jazz/web/projects/WS-CD#action=com.ibm.team.build.viewResult&id=_rVJ18PFGEeyYXLZn0n3zUg&tab=com.ibm.team.build.web.ui.internal.editors.result.overview.OverviewPage channel zfat fails to build: com.ibm.ws.zos.channel.wola_zfat which prevents ANY zfats running Caused by: /home/jazz_build/Build/jbe/build/WS-CD-Open/dev/ant_build/public_imports/internal_imports/test_bundles.xml:80: Failed to build jar file: at aQute.bnd.ant.BndTask.executeBackwardCompatible(BndTask.java:281) at aQute.bnd.ant.BndTask.execute(BndTask.java:116) at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:291) at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) at org.apache.tools.ant.Task.perform(Task.java:348) at org.apache.tools.ant.Target.execute(Target.java:392) at org.apache.tools.ant.Target.performTasks(Target.java:413) at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1399) at org.apache.tools.ant.helper.SingleCheckExecutor.executeTargets(SingleCheckExecutor.java:38) at org.apache.tools.ant.Project.executeTargets(Project.java:1251) at org.apache.tools.ant.taskdefs.Ant.execute(Ant.java:442) ... 255 more Caused by: /home/jazz_build/Build/jbe/build/WS-CD-Open/dev/com.ibm.ws.zos.channel.wola_zfat/test-bundles/wola.channel.test.helper.service/bnd.bnd: bnd failed at aQute.bnd.ant.BndTask.executeBackwardCompatible(BndTask.java:237)

[hutchig]

(From the main 1.5Meg build.log "Zipped up build.log for running ivyBuild" [21-Jun-2022 10:00:18:110 PDT] 00000030 [bnd] 1 ERRORS [21-Jun-2022 10:00:18:111 PDT] 00000030 [bnd] in component wola.channel.test.helper.service.internal.WOLAChannelTestHelperServiceImpl, modified method modify specified but not found [21-Jun-2022 10:00:18:111 PDT] 00000030 [bnd] /home/jazz_build/Build/jbe/build/WS-CD-Open/dev/com.ibm.ws.zos.channel.wola_zfat/test-bundles/wola.channel.test.helper.service/bnd.bnd: bnd failed [21-Jun-2022 10:00:18:111 PDT] 00000030 [bnd]

[hutchig]

https://bnd.bndtools.org/chapters/200-components.html

[hutchig]

All the alcs zfat tests fail.

Errors are of the form: java.io.FileNotFoundException: File '/WebSphere/Misc/jazz_build/jbe_boss0204/jazz/buildsystem/buildengine/eclipse/build/dev/image/output/wlp/clients/zos/bboa1reg' does not exist at com.ibm.ws.zos.ola.alcs.FATSuite.copyWolaClientModules(FATSuite.java:248) OR junit.framework.AssertionFailedError: ALCS compile exit 3 failure at com.ibm.ws.zos.ola.alcs.FATSuite.setUp(FATSuite.java:131) OR junit.framework.AssertionFailedError: ALLOCDS2 completion message not found at com.ibm.ws.zos.ola.alcs.FATSuite.setUp(FATSuite.java:100)

Not a single ALCS test passes in the standard #build (with edited properties) environment.

[hutchig]

The channel tests are also not healthy in the standard #build with properties edited to run them:

[hutchig]

https://wasrtc.hursley.ibm.com:9443/jazz/web/projects/WS-CD#action=com.ibm.team.build.viewResult&id=_3N0xUPLsEeyYXLZn0n3zUg&tab=com.ibm.team.build.web.ui.internal.editors.result.overview.OverviewPage CICS coverage:

com.ibm.ws.zos.channel.wola_test

com.ibm.ws.zos.ola_zfat This also passed (but required an auto-second-run):

com.ibm.ws.zos.connect_test

com.ibm.ws.zos.connect.wola_zfat FAT tests are not 100% reliable first time: WOLAConnectCICSFATTest

But succedded on the second auto-retry:

...and just for CicsTest completeness:

[hutchig]

IMS test coverage here

ola_zfat

channel.wola_test

[hutchig]

Test not yet verified as running OK: com.ibm.ws.zos.channel.wola_zfat com.ibm.ws.zos.channel.wola.zfat.WOLAChannelFATTest testChannelConnect WebSphere/Misc/jazz_build/jbe_zrock063/jazz/buildsystem/buildengine/eclipse/build/dev/image/output/wlp/lib/native/zos/s390x/bbgzscfms: not found

All alcs tests

[epj]

Example z/OS build (since deleted) - https://wasrtc.hursley.ibm.com:9443/jazz/web/projects/WS-CD#action=com.ibm.team.build.viewResult&id=_G6xpsCoUEe2pPfp3nZ4PGw&tab=com.ibm.team.build.web.ui.internal.editors.result.overview.OverviewPage

[hutchig]

build.ztest.xml.disabled are resent in the two 'invalid' testsuites in the above build, one can use a draft PR to rename them for the build @epj

[epj]

I'd been getting file not found errors in the zFATs for the WOLA specific include files. Turns out I'd been trying to use build options which actually causes the build not to include some zos specific parts. Here is what a personal build needs to specify, beyond the defaults you get with a hash-build:

For a zos personal build, specify: fat.buckets.to.run [give the list] fat.test.mode full spawn.zos true

Do NOT specify spawn.common.fats.on.zos
spawn.zos.tests spawn.fullfat.buckets