OpenLiberty / open-liberty

Open Liberty is a highly composable, fast to start, dynamic application server runtime environment
https://openliberty.io
Eclipse Public License 2.0
1.15k stars 592 forks source link

MicroProfile Config 3.1 #25189

Closed Emily-Jiang closed 11 months ago

Emily-Jiang commented 1 year ago

Description

Implement MicroProfile Config 3.1, which just have some TCK updates with new tests as well. The detailed plan review is here.

As part of this feature, SmallRye Config 3.3.0 (2.5.1 previously) will be consumed.


Documents

When available, add links to required feature documents. Use "N/A" to mark particular documents which are not required by the feature.

General Instructions

The process steps occur roughly in the order as presented. Process steps occasionally overlap.

Each process step has a number of tasks which must be completed or must be marked as not applicable ("N/A").

Unless otherwise indicated, the tasks are the responsibility of the Feature Owner or a Delegate of the Feature Owner.

If you need assistance, reach out to the OpenLiberty/release-architect.

Important: Labels are used to trigger particular steps and must be added as indicated.


Prioritization (Complete Before Development Starts)

The (OpenLiberty/chief-architect) and area leads are responsible for prioritizing the features and determining which features are being actively worked on.

Prioritization

Design preliminaries determine whether a formal design, which will be provided by an Upcoming Feature Overview (UFO) document, must be created and reviewed. A formal design is required if the feature requires any of the following: UI, Serviceability, SVT, Performance testing, or non-trivial documentation/ID.

Design Preliminaries

Design

No Design

FAT Documentation

A feature must be prioritized before any implementation work may begin to be delivered (inaccessible/no-ship). However, a design focused approach should still be applied to features, and developers should think about the feature design prior to writing and delivering any code.
Besides being prioritized, a feature must also be socialized (or No Design Approved) before any beta code may be delivered. All new Liberty content must be inaccessible in our GA releases until it is Feature Complete by either marking it kind=noship or beta fencing it.
Code may not GA until this feature has obtained the "Design Approved" or "No Design Approved" label, along with all other tasks outlined in the GA section.

Feature Development Begins

Legal and Translation

In order to avoid last minute blockers and significant disruptions to the feature, the legal items need to be done as early in the feature process as possible, either in design or as early into the development as possible. Similarly, translation is to be done concurrently with development. Both MUST be completed before Beta or GA is requested.

Legal (Complete before Feature Complete Date)

Translation (Complete 1 week before Feature Complete Date)

Innovation (Complete 1 week before Feature Complete Date)

In order to facilitate early feedback from users, all new features and functionality should first be released as part of a beta release.

Beta Code

Beta Blog (Complete 1.5 weeks before beta eGA)

A feature is ready to GA after it is Feature Complete and has obtained all necessary Focal Point Approvals.

Feature Complete

Focal Point Approvals (Complete by Feature Complete Date)

These occur only after GA of this feature is requested (by adding a target:ga label). GA of this feature may not occur until all approvals are obtained.

All Features

Design Approved Features

Remove Beta Fencing (Complete by Feature Complete Date)

GA Blog (Complete by Friday after GM)

Post GA

NottyCode commented 1 year ago

@Emily-Jiang if MP Config only has TCK updates why is it a minor release?

Emily-Jiang commented 1 year ago

@Emily-Jiang if MP Config only has TCK updates why is it a minor release?

According to the TCK process, new TCKs cannot be made to a micro release. What I meant Tck updates includes some tests being updated and new tests added. The MP TCK rules is very similar to Jakarta EE TCK rules.

Emily-Jiang commented 1 year ago

There is no functional update but just some TCK updates. Please can the approvals to add your approval?

Emily-Jiang commented 11 months ago

@LifeIsGood524 @natalie-bernhard @donbourne please can you add approval for this feature

Emily-Jiang commented 11 months ago

@tngiang73 @jhanders34 @hanczaryk @ayoho please add your approval please?

natalie-bernhard commented 11 months ago

@tngiang73 @jhanders34 @hanczaryk please add your approval please?

Issues tagged with No Design Approved do not require Accessibility Focal approval

Emily-Jiang commented 11 months ago

@cbridgha please can you add External approval? This feature has no functionality update except tck updates.

Emily-Jiang commented 11 months ago

@tevans78 please add your approval for demo as I have added to the upcoming Nov EOI agenda.

LifeIsGood524 commented 11 months ago

Hi Emily, the focalApproved:globalization Label is no longer required as discussed in the EOI call yesterday. @mbroz2 is in the process of updating the process and feature template.

If you have validated your translation was returned and resulting PR merged into a driver, you will add the "Translation - Complete" Label.

Other options here: https://github.com/OpenLiberty/open-liberty/labels?q=Translation+

Emily-Jiang commented 11 months ago

Hi Emily, the focalApproved:globalization Label is no longer required as discussed in the EOI call yesterday. @mbroz2 is in the process of updating the process and feature template.

If you have validated your translation was returned and resulting PR merged into a driver, you will add the "Translation - Complete" Label.

Other options here: https://github.com/OpenLiberty/open-liberty/labels?q=Translation+

thanks! I have just learned the new process as I did not manage to attend the EOI call yesterday.

donbourne commented 11 months ago

Serviceability Approval Comment - Please answer the following questions for serviceability approval:

  1. UFO -- does the UFO identify the most likely problems customers will see and identify how the feature will enable them to diagnose and solve those problems without resorting to raising a PMR? Have these issues been addressed in the implementation?

  2. Test and Demo -- As part of the serviceability process we're asking feature teams to test and analyze common problem paths for serviceability and demo those problem paths to someone not involved in the development of the feature (eg. L2, test team, or another development team).
    a) What problem paths were tested and demonstrated? b) Who did you demo to? c) Do the people you demo'd to agree that the serviceability of the demonstrated problem scenarios is sufficient to avoid PMRs for any problems customers are likely to encounter, or that L2 should be able to quickly address those problems without need to engage L3?

  3. SVT -- SVT team is often the first team to try new features and often encounters problems setting up and using them. Note that we're not expecting SVT to do full serviceability testing -- just to sign-off on the serviceability of the problem paths they encountered. a) Who conducted SVT tests for this feature? b) Do they agree that the serviceability of the problems they encountered is sufficient to avoid PMRs, or that L2 should be able to quickly address those problems without need to engage L3?

  4. Which L2 / L3 queues will handle PMRs for this feature? Ensure they are present in the contact reference file and in the queue contact summary, and that the respective L2/L3 teams know they are supporting it. Ask Don Bourne if you need links or more info.

  5. Does this feature add any new metrics or emit any new JSON events? If yes, have you updated the JMX metrics reference list / Metrics reference list / JSON log events reference list in the Open Liberty docs?

Emily-Jiang commented 11 months ago

@donbourne since this feature is No Design Approval, according to the current process, this feature does not need Serviceability Approval. Thanks for looking into it!

Emily-Jiang commented 11 months ago

I only need @cbridgha @tevans78 @ayoho to approve this feature. All other approvers: please ignore this feature.