search

OpenLiberty / open-liberty

Open Liberty is a highly composable, fast to start, dynamic application server runtime environment
https://openliberty.io
Eclipse Public License 2.0
1.15k stars 591 forks source link

Can we remove the overlayed WithSpan annotation #26041

Open Azquelt opened 1 year ago

Azquelt commented 1 year ago

We currently have our own version of the WithSpan to make it an interceptor binding. We should look to see if we can do this with a CDI extension instead.

benjamin-confino commented 1 year ago

I think we could, but I don't think we should.

The current setup is more readable (no eclipse redlines if it imports our definition via the target runtime) and provides better performance than using an extension to get around WithSpan's limited options for Target. The readability is the important part.