FAT tests for new CDI 4.1 features - Githubissues

OpenLiberty / open-liberty

Open Liberty is a highly composable, fast to start, dynamic application server runtime environment

https://openliberty.io

Eclipse Public License 2.0

1.14k stars 588 forks source link

FAT tests for new CDI 4.1 features #27826

Open Azquelt opened 6 months ago

Azquelt commented 6 months ago

The following new features may require additional FAT tests, depending on whether we do #27824 and whether TCK coverage is good enough.

getInterceptorBindings added to InvocationContext
@Priority can be applied directly to a producer method or field
BeanContainer.isMatchingBean and isMatchingEvent
Injection of ELAwareBeanManager

yasmin-aumeeruddy commented 2 weeks ago

Test for getInterceptorBindings added to InvocationContext: https://github.com/jakartaee/cdi-tck/blob/master/impl/src/main/java/org/jboss/cdi/tck/interceptors/tests/contract/invocationContext/InvocationContextTest.java#L125-L147

@Priority can be applied directly to a producer method or field: https://github.com/jakartaee/cdi-tck/commit/16b7faa81ea34bffb3f8da4807939670af65ae85

BeanContainer.isMatchingBean and isMatchingEvent: https://github.com/jakartaee/cdi-tck/commit/8d19cf7e03c3535f655c2754c0ebcf5437aa3008

I can't find any TCK tests covering the injection of ELAwareBeanManager

Azquelt commented 2 weeks ago

Cool, so if we run the core TCK as a FAT test (#27824), we shouldn't need FAT tests for those features.