OpenLiberty / open-liberty

Open Liberty is a highly composable, fast to start, dynamic application server runtime environment
https://openliberty.io
Eclipse Public License 2.0
1.13k stars 572 forks source link

fix issue with security re-auth/restore and GRPC #28346

Closed isaacrivriv closed 1 day ago

isaacrivriv commented 1 week ago

Added change to fix issue with security re-auth/restore and GRPC fixes #28459

isaacrivriv commented 1 week ago

!build

LibbyBot commented 1 week ago

Your personal build request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=4d3602a5-0305-4fec-acd0-064afcfb545a

Target locations of links might be accessible only to IBM employees.

LibbyBot commented 1 week ago

Your personal build request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=e9337cea-6e13-4e97-8af7-02981e54b054

Target locations of links might be accessible only to IBM employees.

LibbyBot commented 1 week ago

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=e9337cea-6e13-4e97-8af7-02981e54b054 has errors/failures.

LibbyBot commented 1 week ago

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=4d3602a5-0305-4fec-acd0-064afcfb545a has errors/failures.

isaacrivriv commented 1 week ago

!build

spawn.fullfat.buckets=com.ibm.ws.grpc_fat

LibbyBot commented 1 week ago

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=40316008-9893-4a77-9541-7d00f897f231

Target locations of links might be accessible only to IBM employees.

LibbyBot commented 1 week ago

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=d4ab7925-582a-455a-9f05-46f0204e01ad

Target locations of links might be accessible only to IBM employees.

LibbyBot commented 1 week ago

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=40316008-9893-4a77-9541-7d00f897f231 has errors/failures.

LibbyBot commented 1 week ago

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=d4ab7925-582a-455a-9f05-46f0204e01ad has errors/failures.

isaacrivriv commented 1 week ago

!build

spawn.fullfat.buckets=com.ibm.ws.grpc_fat

LibbyBot commented 1 week ago

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=fda47d19-9be3-4555-a073-d5d875d66c4b

Target locations of links might be accessible only to IBM employees.

LibbyBot commented 1 week ago

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=45a80d19-bd2c-4761-8f8f-cccc86fa9157

Target locations of links might be accessible only to IBM employees.

LibbyBot commented 1 week ago

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=45a80d19-bd2c-4761-8f8f-cccc86fa9157 completed.

isaacrivriv commented 1 week ago

Good news is that the changes seem to work addressing the issue. It seems related to accumulating data when using oidc for a relogin and continue. Kicking off another build to verify but since all the buckets failed the same way last time I'm confident about this fix

isaacrivriv commented 1 week ago

!build

spawn.fullfat.buckets=com.ibm.ws.grpc_fat

LibbyBot commented 1 week ago

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=5ca0082d-326a-4720-83d2-9e6d8b9b44db

Target locations of links might be accessible only to IBM employees.

LibbyBot commented 1 week ago

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=2b28f78e-809d-430a-9e25-6e83fcb675a8

Target locations of links might be accessible only to IBM employees.

LibbyBot commented 1 week ago

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=5ca0082d-326a-4720-83d2-9e6d8b9b44db has errors/failures.

LibbyBot commented 1 week ago

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=fda47d19-9be3-4555-a073-d5d875d66c4b has errors/failures.

LibbyBot commented 1 week ago

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=2b28f78e-809d-430a-9e25-6e83fcb675a8 completed.

fritze2 commented 5 days ago

Would this also address the timeouts in the other two buckets we've seen? I'll run a pipeline to find out tomorrow. !build

spawn.fullfat.buckets=com.ibm.ws.grpc_fat,io.openliberty.springboot.fat30_fat,com.ibm.ws.springboot.fat20_fat

LibbyBot commented 5 days ago

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=a00f08d7-c261-4161-a4c7-077f9b8a91f6

Target locations of links might be accessible only to IBM employees.

LibbyBot commented 5 days ago

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=ecc9d532-4856-4d73-992b-b52dcf0511f6

Target locations of links might be accessible only to IBM employees.

isaacrivriv commented 5 days ago

Thanks @fritze2! We're working on a review this week with the GRPC experts. Hoping to get this merged in ASAP!

As for the other timeouts, I'm not sure. I haven't looked into the other defects associated with those buckets. This fix is very GRPC specific, so I would not think the springboot buckets use the feature and therefore would probably not be affected by this change.

fritze2 commented 4 days ago

The pipeline confirmed it has no change in the springboot buckets, and I've found the pause in those buckets that leads to a timeout is tracing to java.nio.channels.Selector, so I will try updating to the latest JDK in hopes a bug was patched, and if that doesn't help, then I'll open a defect that we can get help from the springboot devs on.

LibbyBot commented 4 days ago

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=ecc9d532-4856-4d73-992b-b52dcf0511f6 has errors/failures.

LibbyBot commented 3 days ago

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=a00f08d7-c261-4161-a4c7-077f9b8a91f6 has errors/failures.

isaacrivriv commented 3 days ago

!build

spawn.fullfat.buckets=com.ibm.ws.grpc_fat

LibbyBot commented 3 days ago

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=8dd9d651-21f8-4c54-9765-d7ed59a39a74

Target locations of links might be accessible only to IBM employees.

LibbyBot commented 3 days ago

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=11bf5fb2-1b30-4c25-ac22-7b7c3ff43d79

Target locations of links might be accessible only to IBM employees.

LibbyBot commented 3 days ago

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=11bf5fb2-1b30-4c25-ac22-7b7c3ff43d79 has errors/failures.

LibbyBot commented 2 days ago

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=8dd9d651-21f8-4c54-9765-d7ed59a39a74 completed.

isaacrivriv commented 2 days ago

libby

pnicolucci commented 1 day ago

@isaacrivriv we should probably have a release bug issue for this as well.

pnicolucci commented 1 day ago

libby

LibbyBot commented 1 day ago

Code analysis and actions

DO NOT DELETE THIS COMMENT.

isaacrivriv commented 1 day ago

Last change was an update to copyrights and latest build contained all GRPC FATs passing at 100%. Should be safe to merge in