OpenLiberty / open-liberty

Open Liberty is a highly composable, fast to start, dynamic application server runtime environment
https://openliberty.io
Eclipse Public License 2.0
1.16k stars 597 forks source link

Feature Test Summary for MpTelemetry-2.0 #28986

Closed yasmin-aumeeruddy closed 1 week ago

yasmin-aumeeruddy commented 4 months ago

Test Strategy

List of FAT projects affected

Test strategy

External open source packages have been updated from OpenTelemetry version 1.29.0 to 1.39.0

The feature is compatible with older MicroProfile versions and older Java EE versions (7+) . Therefore, Repeats are required for all of the aforementioned projects for MpTelemetry-1.1 with the following MicroProfile versions:

Any test that currently runs against mpTelemetry-1.1 should also work with mpTelemetry-2.0. However, test repeats for mpTelemetry 2.0 should test the updated SemanticAttributes class . The class has changed package from io.opentelemetry.semconv.trace.attributes to io.opentelemetry.semconv In addition,Jaeger is now a deprecated trace exporter confiuration value so tests for this exporter option should not be repeated for mpTelemetry-2.0 (Telemetry data is sent via OTLP to a jaeger backend instead).

Tests have been created for:

MpTelemetry 2.0 is compatible with Java 8. The following buckets repeat tests with this Java version:

Confidence score:

4 - We have delivered all automated testing we believe is needed for the golden paths of this feature and have good coverage of the error/outlying scenarios. While more testing of the error/outlying scenarios could be added we believe there is minimal risk here and the cost of providing these is considered higher than the benefit they would provide.

benjamin-confino commented 3 months ago

Currently some of the new features are explicitly tested in both runtime and app mode, but a lot of the old stuff is tested in whatever way the configuration enables (usually runtime).

We need to setup a system where every test runs on both, then carve out exceptions for the ones that are only supposed to work in one instance.

benjamin-confino commented 3 months ago

Myself and Yasmin went through and identified all areas we need new tests to ensure we're covered on both runtime and appmode. I am now confident on that issue.

dave-waddling commented 3 months ago

Hi, thanks for completing the FTS, the content passes review. However, until RTC:301434 is resolved I can't grant FAT Focal approval.

dave-waddling commented 1 week ago

@yasmin-aumeeruddy based on our Slack discussion I'm willing to grant approval at this time, I'll add it to the feature issue now.